[IMP] remove dependency on jwt library #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanhDodeurOdoo
force-pushed
the
master-internal-jwt-tso
branch
6 times, most recently
from
0deba45 to
9d4f078
Compare
ThanhDodeurOdoo
added
backwards-compatible: old server + new client
ThanhDodeurOdoo
force-pushed
the
master-internal-jwt-tso
branch
3 times, most recently
from
6577df8 to
4750916
Compare
ThanhDodeurOdoo
force-pushed
the
master-internal-jwt-tso
branch
6 times, most recently
from
9963efd to
0d8ed3c
Compare
alexkuhn
approved these changes
Apr 2, 2025
seb-odoo
reviewed
Apr 2, 2025
src/services/auth.js
Outdated
| * @returns {string} - The signed JWT token | ||
| * @throws {AuthenticationError} | ||
| */ | ||
| export function sign(payload, key = jwtKey, { algorithm = ALGORITHM.HS256 } = {}) { |
There was a problem hiding this comment.
Do we need to bother with all of these params if we're only using the default one?
In particular if ALGORITHM_FUNCTIONS doesn't support any other one anyway?
There was a problem hiding this comment.
The code is heavily inspired by the lib, IMO this is fine to copy them even if we only have a single algorithm at hand now.
There was a problem hiding this comment.
I kept them to keep the expected API of JWT functions and to make it more clear in the code what are JWT core features vs parameters, it's also more similar to our python implementation that way
ThanhDodeurOdoo
force-pushed
the
master-internal-jwt-tso
branch
2 times, most recently
from
b380313 to
c0f6aac
Compare
Instead, it is now a local implementation of JWT, this makes the server less dependent on external libraries for its security and removes a potential source of dependency injection. This commit also removes unnecessary async/await (the old jsonwebtoken was also used synchronously).
ThanhDodeurOdoo
force-pushed
the
master-internal-jwt-tso
branch
from
c0f6aac to
01ec896
Compare
|
just added better typing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, it is now a local implementation of JWT, this makes
the server less dependent on external libraries for its security
and removes a potential source of dependency injection.
This commit also removes unnecessary async/await
(the old jsonwebtoken was also used synchronously).