Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created estate module for technical training #345

Draft
wants to merge 15 commits into
base: 18.0
Choose a base branch
from

Conversation

mebh-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Feb 11, 2025

Pull request status dashboard

…ng the invoicing with estate module, completed till chapter 13 and changed the code according to the coding guidelines.
Completed qweb, web controllers, PDF reports.
Analyzed and made required changes in the code as suggested in the PR.
Competed with Unit testing of the code.
Completed wizard exercise that was given,made wizard folder inside estate module

def action_accept(self):
for offer in self:
if offer.property_id.state == 'sold' or 'cancel':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "In" instead of or.

<strong>Property Status: </strong>
<span t-field="property.state"/>
</div>
<t t-set="offers" t-value="property.mapped('offer_ids')"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use mapped(). can you check other way.

Comment on lines +16 to +17


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line.

Command.create({
'name': 'Administrative Fees',
'quantity': 1,
'price_unit': '100.00'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'price_unit': '100.00'
'price_unit': 100.00

was a string, now a float.

Comment on lines +85 to +87
offer.property_id.selling_price = offer.price
offer.property_id.buyer_id = offer.partner_id
offer.property_id.state = 'offer_accepted'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check other way to update this,

'estate.property', string="Properties", domain=[("state", "in", ["new", "offer_received"])])

def action_make_offer(self):
offer = self.env['estate.property.offer']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to define,

Comment on lines +21 to +22
'demo': [
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this if not needs.

'license': 'LGPL-3',

'description': '''
Description text

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add related description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants