Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Real Estate for Technical Training #347

Draft
wants to merge 13 commits into
base: 18.0
Choose a base branch
from

Conversation

hsha-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Feb 11, 2025

Pull request status dashboard

@@ -0,0 +1,2 @@
from . import models
# from . import views

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary comments.

"depends": ["base"],
"application": True,
"description": """
Real Estate Test Description

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide appropriate description.

@@ -0,0 +1,140 @@
from odoo import models, fields, api

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import as per per coding guideline.

("west", "West"),
],
)
# Following active field refer to the visiblity of field in search

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add comments if required.

property_seller_id = fields.Many2one(
"res.users", string="Salesman", default=lambda self: self.env.user
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra blank lines

_description = "Real Estate Property Tags"

name = fields.Char(string="Tag", required=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines and extra comments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra blanks line and comments.

<menuitem id="estate_model_menu_action" action="estate_model_action" />
</menuitem>
<menuitem id="estate_type_first_level_menu" name="Settings">
<menuitem id="estate_type_model_menu_action" action="estate_type_model_action" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space as per suggested.

@@ -0,0 +1,11 @@
<odoo>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing <?xml version="1.0" encoding="utf-8"?>

</form>
</field>
</record>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants