[ADD] created estate app

[duau-odoo]

No description provided.

[robodoo]

[rugo-odoo]

A few things.

[rugo-odoo]

By default, the label will take the name of the field and capitalize it. So in this case it will be, by default, Garage. So we don't need to manually add it.

[rugo-odoo]

Suggested change

	garden_orientation = fields.Selection(
	[("north", "North"),
	("south", "South"),
	("east", "East"),
	("west", "West")],
	"Garden Orientation")
	garden_orientation = fields.Selection([
	("north", "North"),
	("south", "South"),
	("east", "East"),
	("west", "West"),
	], "Garden Orientation")

The advantage of doing it like this is that if we need to add a value, we won't break git history.

[rugo-odoo]

Some extra indents in here.

[hupo-odoo]

Good job! It's impressive what you've done in 2 days 😄

[hupo-odoo]

Suggested change

	'|',
	('status', '=', 'new'),
	('status', '=', 'offer_received')]"
	('status', 'in', ('new','offer_received'))

[hupo-odoo]

Suggested change

	if record.property_id.offer_ids.mapped("status").count("accepted") >= 1:
	if offer.property_id.offer_ids.filtered(lambda o: o.status == 'accepted'):

using filtered is cleaner

[hupo-odoo]

Suggested change

	for record in self:
	for offer in self:

record is too vague and when used in huge compute functions, you sometime forgot what self exactly is

[hupo-odoo]

Suggested change

	for record in self:
	if record.create_date:
	record.date_deadline = fields.Date.add(record.create_date, days=record.validity)
	else:
	record.date_deadline = fields.Date.add(fields.Date.today(), days=record.validity)
	for offer in self:
	create_date = offer.create_date or fields.Date.today()
	record.date_deadline = fields.Date.add(create_date, days=record.validity)

a bit more concise 😄

[hupo-odoo]

Suggested change

	for record in self:
	if record.offer_ids:
	record.best_offer = max(record.offer_ids.mapped("price"))
	else:
	record.best_offer = 0
	for property in self:
	property.best_offer = max(property.offer_ids.mapped("price")) if property.offer_ids else 0.0

or you could even do simpler:

property.best_offer = max(property.offer_ids.mapped("price") + [0.0])

for simple if else, better use one line

Also, best_offer is a Float, so it's best practice to assign the value 0.0 directly instead of 0

[hupo-odoo]

Suggested change

	for record in self:
	if record.status == "sold":
	raise exceptions.UserError("Sold properties cannot be cancelled")
	record.status = "cancelled"
	if self.filtered(lambda property: property.status == "sold"):
	raise exceptions.UserError("Sold properties cannot be cancelled")
	self.status = "cancelled"

here you don't even need to loop on the records manually 😄
same comment applies for function below