[IMP] tutorials: first commit #353
Conversation
modules: tutorials/awesome_clicker files: __init__.py first commit following the instructions of the tutorials
|
|
estate/__init__.py
Outdated
| @@ -0,0 +1,4 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This is not necessary in Python files for a long time already.
There are some that are still there in the code for historical reason, but please don't add them on new files 🙂
AFAIK, the licensing is also not really necessary to add on each file since it's defined in the manifest for the whole module.
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | ||
| from dateutil.relativedelta import relativedelta | ||
| from odoo import fields, models | ||
|
|
There was a problem hiding this comment.
Two empty lines between imports and class.
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Date(default=fields.Date.today()+relativedelta(months=3), copy=False) |
There was a problem hiding this comment.
Just a small note:
fields.Date.today() will actually give you the server time, if you want to have the actual today of the user (which is the case most of the time for business logic) you'll have to use context_today.
estate/models/estate_property.py
Outdated
| state = fields.Selection( | ||
| selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), | ||
| ('sold', 'Sold'), ('cancelled', 'Cancelled')], | ||
| copy=False, | ||
| default='new', | ||
| required=True |
There was a problem hiding this comment.
| state = fields.Selection( | |
| selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), | |
| ('sold', 'Sold'), ('cancelled', 'Cancelled')], | |
| copy=False, | |
| default='new', | |
| required=True | |
| state = fields.Selection( | |
| selection=[ | |
| ('new', 'New'), | |
| ('offer_received', 'Offer Received'), | |
| ('offer_accepted', 'Offer Accepted'), | |
| ('sold', 'Sold'), ('cancelled', 'Cancelled'), | |
| ], | |
| copy=False, | |
| default='new', | |
| required=True, |
Don't hesitate to use the space if it makes it more readable. Also it's a good practice to add a , even on the last parameter in such case: if someone needs to add something later on, he won't have to modify the last line to add it, and that will keep the git history very clean.
estate/views/estate_menus.xml
Outdated
| @@ -0,0 +1,7 @@ | |||
| <odoo> | |||
| <menuitem id="estate_menu_root" name="Real Estate"> | |||
| <menuitem id="estate_first_level_menu" name="Advertisements"> | |||
There was a problem hiding this comment.
We also have convention for xml ids, although they are quite recent and therefore not that often enforced in the code for the moment.
I suggest you read this section again and update them accordingly 🙂
https://www.odoo.com/documentation/master/contributing/development/coding_guidelines.html#xml-ids-and-naming
awesome_clicker/__init__.py
Outdated
| # -*- coding: utf-8 -*- | ||
|
|
||
| #TEST COMMIT | ||
|
|
||
| print("test") |
estate/models/estate_property.py
Outdated
| partner_id = fields.Many2one( | ||
| 'res.partner', string='Buyer', | ||
| ) |
There was a problem hiding this comment.
Inline all of those. Let's stay consistent with the indentation we did previously.
| <field name="bedrooms"/> | ||
| <field name="living_area" string="Living Area (sqm)"/> | ||
| <field name="facades"/> | ||
| <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/> |
There was a problem hiding this comment.
| <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/> | |
| <filter name="available" string="Available" domain="['('state', 'in', ('new', 'offer_received'))]"/> |
modules: tutorials/awesome_clicker
files: init.py
first commit following the instructions of the tutorials