-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18.0 technical training lmer #358
Open
LuneMercier
wants to merge
43
commits into
odoo:18.0
Choose a base branch
from
odoo-dev:18.0-technical_training-lmer
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create empty module Tutorial Chapter 2
Creation of a new model to store estate properties following the 3rd chapter of the tutorial.
Line on selection field was too long before
No access rights were setup before that, the model was thus inaccessible. Chapter 4 of tutorial
d77ea84
to
c55b96a
Compare
Creation of a basic action for the Estate property model. Chapter 5 of the tutorial
Make availability date and selling price not copied on duplication Make selling price readonly Following Chapter 5 of tutorial
On model property add default values, for the availability it is computed three months from now From tutorial chapter 5
Create menus to make the ap accessible from the main dashboard and to allow creation of Estate property from the action From tutorial Chapter 5
From tutoral Chapter 5
Create state field to track relation to this estate from the company From tutorial chapter 5
rugo-odoo
suggested changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few details
rugo-odoo
suggested changes
Feb 18, 2025
Create custom search, form and list views in order to have a better UX Following chapter 6 of the tutorial
Create models like tag, type and offers to complete and allow many more informations to be sotred in the database. From chapter 7 of tutorial
Add computation on new offer fields setting deadline. Add computation on new property field total area that sums the living and garden area Add computation on new property field best offer that selects the highest price of all offers From chapter 8 of tutorial
rugo-odoo
suggested changes
Feb 19, 2025
Make indentation coherent between the lists used as arguments Add ',' after last element of lists to avoid breaking git history when adding an element
Co-authored-by: rugo-odoo <[email protected]>
Co-authored-by: rugo-odoo <[email protected]>
Add license and base_setup dependency
Add descriptions on all models, improve the one for the estate.property model
Add action to cancel or sell a property and set the state Add action to accept or refuse an offer and updating all the related fields
Add sql constraints for prices to be strictly positive and tag and type names to be unique Add python constraint on selling price to avoid selling at less than 80% of the expected price
Create action button and fields to allow to see the offers linked to a certain property type From Chapter 11 of the tutorial
Make creation of offers forced to have an higher price than any other offers Make deletion of a property impossible if it's not new or cancelled
Use inheritance to improve the user data and view with the linked properties From chapter 12 of tutorial
Create new module extending estate capabilities to allow to create invoice on propertie sale. From Chapter 13 of tutorial
hupo-odoo
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! JS is coming soon 😄
Sudo is not necessary
Add docstrings everywhere
ea59a32
to
2002a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.