18.0 Technical onboarding guja #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added init and manifest files
|
|
clbr-odoo
approved these changes
Feb 18, 2025
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models | |||
There was a problem hiding this comment.
Missing empty line at the end of all files 🙂
| 'demo': [ | ||
| ], | ||
| 'application': True, | ||
| 'installable': True |
There was a problem hiding this comment.
You'll need to add a license to get rid of the runbot warning and turn it to green 🙂
| @@ -0,0 +1,23 @@ | |||
| from odoo import fields, models | |||
|
|
|||
There was a problem hiding this comment.
Two lines between the imports and the class.
estate/models/estate_property.py
Outdated
| from odoo import fields, models | ||
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate_property" |
There was a problem hiding this comment.
Suggested change
| _name = "estate_property" | |
| _name = "estate.property" |
By convention, models _name use dots separators.
estate/models/estate_property.py
Outdated
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Datetime() |
There was a problem hiding this comment.
Suggested change
| date_availability = fields.Datetime() | |
| date_availability = fields.Date() |
Maybe a Date type is enough ? 🤔
rugo-odoo
suggested changes
Feb 18, 2025
estate/__manifest__.py
Outdated
Comment on lines
1
to
3
| # -*- coding: utf-8 -*- | ||
| # Part of Odoo. See LICENSE file for full copyright and licensing details. | ||
|
|
estate/__manifest__.py
Outdated
| 'name': "Real Estate", | ||
| 'version': '1.0', | ||
| 'depends': ['base'], | ||
| 'author': "Author Name", |
There was a problem hiding this comment.
Suggested change
| 'author': "Author Name", | |
| 'author': "Odoo S.A.", |
estate/__manifest__.py
Outdated
| 'author': "Author Name", | ||
| 'category': 'Category', | ||
| 'description': """ | ||
| Description text |
estate/__manifest__.py
Outdated
| Description text | ||
| """, | ||
| 'website': 'https://www.odoo.com/page/estate', | ||
| # data files always loaded at installation |
There was a problem hiding this comment.
Those comments don't add any value 😬
estate/__manifest__.py
Outdated
Comment on lines
20
to
21
|
|
||
|
|
There was a problem hiding this comment.
Extra space. We waste bits with that, think of the planet 😄
estate/__manifest__.py
Outdated
Comment on lines
24
to
25
| 'demo': [ | ||
| ], |
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Datetime(copy=False, default=fields.Datetime.add(fields.Datetime.now(), months=+3)) |
estate/models/estate_property.py
Outdated
| garden_area = fields.Integer() | ||
| garden_orientation = fields.Selection( | ||
| string='Orientation', | ||
| selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')], |
There was a problem hiding this comment.
Suggested change
| selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')], | |
| selection=[ | |
| ('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West'), | |
| ], |
Like this we can add new values without breaking the git history.
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models | |||
…eadline date, and the garden
…, and accept and refuse button for offers
…xpected and selling price, tag and type names
…, attibutes and options, search and stat button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added init and manifest files