Lezgo

[AarnorDeDardaliel]

No description provided.

[robodoo]

[hupo-odoo]

Good job for the work! You've already done a lot for the first day. Keep going 😄

[hupo-odoo]

no need for all this 😃
the coding: utf-8 isn't necessary since a few versions

[hupo-odoo]

I don't think this is the right place for this line of code

[hupo-odoo]

some of your file are missing an empty line at the bottom. You can check on the PR the files with a warning at the bottom to see which ones.

[hupo-odoo]

Suggested change

	state = fields.Selection(
	string='State',
	selection = [('new', "new"), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')],
	default='new'
	)
	state = fields.Selection(
	string='State',
	selection = [
	('new', "new"),
	('offer_received', 'Offer Received'),
	('offer_accepted', 'Offer Accepted'),
	('sold', 'Sold'),
	('cancelled', 'Cancelled')
	],
	default='new',
	)

just styling preference. More globally, don't hesitate to give space to your code.

Also don't forget the coma on the last line, because if someone one day must add another attibute to the field, he'll have to add the coma, which will force him to modify your line of code, therefore changing the git history of this line.

[hupo-odoo]

what does the class mb32 do in runbot ? Not sure it exists

[hupo-odoo]

Suggested change

	<filter string="Available" name="available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
	<filter string="Available" name="available" domain="[('state', 'in', ('new', 'offer_received'))]"/>

a bit more concise

[hupo-odoo]

imports must be ordered according to https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html#imports

[rugo-odoo]

Noob.

(hahaha 😄)

[rugo-odoo]

No licence ?

[rugo-odoo]

Missing empty line at end of file.

[rugo-odoo]

By default, the label will be the name of the field capitalize. In this case, it will be Active so there is no need to define it.

[rugo-odoo]

Suggested change

	selection = [('north', "North"), ('south', 'South'), ('east', 'East'), ('west', 'West')]
	selection = [
	('north', "North"),
	('south', 'South'),
	('east', 'East'),
	('west', 'West'),
	]

This is better. We can add values without breaking the git history.

[rugo-odoo]

Suggested change

	record.best_price = max(record.property_offer_ids.mapped('price')) if record.property_offer_ids else 0.0
	record.best_price = max(record.property_offer_ids.mapped('price') + [0])

[rugo-odoo]

Suggested change

	if self.state == 'sold':
	raise UserError("You cannot cancel a sold property")
	elif self.state == 'cancelled':
	raise UserError("Property already cancelled")
	else:
	self.state = 'cancelled'
	if self.state == 'sold':
	raise UserError("You cannot cancel a sold property")
	if self.state == 'cancelled':
	raise UserError("Property already cancelled")
	self.state = 'cancelled'

[rugo-odoo]

Suggested change

	if self.status == 'accepted':
	raise UserError('Offer already accepted')
	else: self.property_id.action_accept_offer(self)
	if self.status == 'accepted':
	raise UserError('Offer already accepted')
	self.property_id.action_accept_offer(self)

[rugo-odoo]

What's mb32 ?

[rugo-odoo]

Extra spaceeeee.

[rugo-odoo]

Pretty sure we don't need this.