[ADD] estate: initial Real Estate module with models, views, and rela… #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Introduce the base structure of the Real Estate application as per Odoo 18 developer tutorial, covering the foundational data model, views, menus, access rights, and key relationships. This commit adds: - A new module named `estate`. - The main model `estate.property` with relevant business fields (name, price, expected price, description, living area, garden, garage, etc.). - Custom menus, actions, form and list views for `estate.property`. - Field attributes like `readonly`, `copy`, `required`, and default values. - Access rights through `ir.model.access.csv` for developers. - Multiple record filtering using `domain`, `search`, and view buttons. - Related models: - estate.property.type`: Many2one for property types. - estate.property.tag`: Many2many tags with selection UI. - estate.property.offer`: One2many offer list per property with inline editing - Links to existing models: `res.partner` (buyer), `res.users` (salesperson). - Navigation enhancements through related fields and smart buttons. - Search enhancements using filters for related fields like tags and type. The goal of this commit is to build a working foundation of the real estate sales module including a robust data model, basic UI, and relations required for future business logic and workflow implementation. task-001 (Chapter 1–7 Odoo 18 Developer Tutorial)
|
|
Enhance the Real Estate module by implementing computed fields, onchange
behavior, SQL constraints, and business logic for handling property offers as
outlined in Chapters 9 and 10 of the Odoo 18 Developer Tutorial.
This commit adds:
- Computed fields:
- `total_area`: combines living and garden areas.
- `best_price`: dynamically shows the highest offer on a property.
- Onchange method to auto-fill garden attributes when the garden is checked
- Python constraints using `@api.constrains` to:
- Ensure selling price is at least 90% of expected price.
- Validate date availability is not in the past.
- SQL-level check constraints to enforce:
- `expected_price > 0` on estate.property.
- `price > 0` on estate.property.offer.
- Action methods for accepting and refusing property offers:
- Accepting sets offer status and updates property selling price/buyer.
- Refusing only updates offer status.
- Constraints ensure only one offer can be accepted per property.
- Improved inline editing experience in offer list view.
- Readonly fields, computed badges, and smart button usability refinements.
These changes enforce critical business rules and improve user feedback,
ensuring data consistency and meaningful interactions within the Real
Estate flow.
task-002 (Chapter 9–10 Odoo 18 Developer Tutorial)
adsh-odoo
reviewed
May 9, 2025
There was a problem hiding this comment.
Hello @raaa-odoo
Nice work overall looks good.
Few comments mostly related to coding guidelines and nitpicking.
Cheers!!
There was a problem hiding this comment.
Need blank line at EOF.
Please check other occurrences aslo.
| string="Offers" | ||
| ) | ||
|
|
||
| tag_ids = fields.Many2many("estate.property.tag", string="Tags", widget="many2many_tags" ) |
There was a problem hiding this comment.
widgets are provided on the field in XML side. HINT: refer codebase
Runbot build is failing due to this.
Comment on lines
+1
to
+3
| from odoo import fields, api, models | ||
| from datetime import timedelta | ||
| from odoo.exceptions import UserError |
There was a problem hiding this comment.
Suggested change
| from odoo import fields, api, models | |
| from datetime import timedelta | |
| from odoo.exceptions import UserError | |
| from datetime import timedelta | |
| from odoo import api, fields, models | |
| from odoo.exceptions import UserError |
Generally, we follow a convention where we import the external libraries first, and then we make imports from Odoo in alphabetical order.
https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html#python
Comment on lines
+3
to
+4
| from odoo.exceptions import UserError | ||
| from odoo.exceptions import ValidationError |
| for record in self: | ||
| record.total_area = record.living_area + record.garden_area | ||
|
|
||
| best_price = fields.Float("Best Offer", compute="_compute_best_price", store=True) |
There was a problem hiding this comment.
All field definitions should be together, so this needs to be moved up.
And why we need to store this field.
Comment on lines
+149
to
+160
| _sql_constraints = [ | ||
| ( | ||
| "check_expected_price_positive", | ||
| "CHECK(expected_price > 0)", | ||
| "The expected price must be strictly positive.", | ||
| ), | ||
| ( | ||
| "check_selling_price_positive", | ||
| "CHECK(selling_price >= 0)", | ||
| "The selling price must be positive.", | ||
| ), | ||
| ] |
There was a problem hiding this comment.
The definitions of constraints should be after the field definition.
Hint: refer code base.
Comment on lines
+28
to
+50
| <!-- "Both are correct" | ||
|
|
||
| <odoo> | ||
| <menuitem id="estate_menu_root" name="Real Estate" /> | ||
|
|
||
| <menuitem id="estate_menu_property" name="Properties" | ||
| parent="estate_menu_root" /> | ||
|
|
||
| <menuitem id="estate_menu_property_action" | ||
| parent="estate_menu_property" | ||
| action="estate_property_action" /> | ||
| </odoo> | ||
|
|
||
| ________________________________________________________________________________________________ | ||
|
|
||
| <odoo> | ||
| <menuitem id="estate_menu_root" name="Real Estate"> | ||
| <menuitem id="estate_first_level_menu" name="Properties"> | ||
| <menuitem id="estate_property_menu_action" action="estate_property_action"/> | ||
| </menuitem> | ||
| </menuitem> | ||
| </odoo> | ||
|
|
| <field name="tag_ids" widget="many2many_tags" /> | ||
| </group> | ||
| </page> | ||
|
|
There was a problem hiding this comment.
An unnecessary blank line. Need to be checked for other occurrences also.
| <header> | ||
| <group> | ||
| <field name="name" nolabel="1" | ||
| style="font-size: 28px; font-weight: bold;" /> |
There was a problem hiding this comment.
Suggested change
| style="font-size: 28px; font-weight: bold;" /> | |
| style="font-size: 28px; font-weight: bold;"/> |
Need to change other places also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions
Introduce the base structure of the Real Estate application as per Odoo 18 developer tutorial, covering the foundational data model, views, menus, access rights, and key relationships.
This commit adds:
estate.estate.propertywith relevant business fields (name, price, expected price, description, living area, garden, garage, etc.).estate.property.readonly,copy,required, and default values.ir.model.access.csvfor developers.domain,search, and view buttons.res.partner(buyer),res.users(salesperson).The goal of this commit is to build a working foundation of the real estate sales module including a robust data model, basic UI, and relations required for future business logic and workflow implementation.
task-001 (Chapter 1–7 Odoo 18 Developer Tutorial)