[ADD] estate: New module to manage estates #814
Conversation
|
|
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
2 times, most recently
from
5f9528b to
8bf2ec2
Compare
|
Actually, the |
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
3 times, most recently
from
b008594 to
36574bb
Compare
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
a905a17 to
716c663
Compare
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
41b9431 to
2a00cff
Compare
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
11b3175 to
759af29
Compare
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
759af29 to
d5a3567
Compare
There was a problem hiding this comment.
Not much to say.
There are remaining ' vs ", some extra unneeded files, etc... and fixes in late commits instead of "since the start".
But better continue with further training, if you have time later and want to practice more git cleanups, that's always possible too.
estate/models/estate_property.py
Outdated
| @api.ondelete(at_uninstall=False) | ||
| def _unlink_if_state_is_new_or_cancelled(self): | ||
| if any(record.state not in ('new', 'canceled') for record in self): | ||
| raise UserError("Only new and canceled properties can be deleted.") |
There was a problem hiding this comment.
Those strings are not implicitly translated, they have to be explicitly translated using _ (from odoo import _)
Oh, you actually do it in further commits. This is also a reason to include the fix inside the original commit. 😉
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "python.languageServer": "None" | |||
There was a problem hiding this comment.
Of course, on real PRs, such files wouldn't be included.
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
a4cf5b7 to
374b700
Compare
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
7aec092 to
d704def
Compare
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
54166bc to
f93b2e8
Compare
| onWillUpdateProps(() => { | ||
| this.chart.destroy(); | ||
| this.renderChart(); | ||
| }) |
There was a problem hiding this comment.
At this stage, this.props are the old values. onWillUpdateProps's function receives the new values as parameter.
baje-odoo
force-pushed
the
18.0-fix-invoices-baje
branch
from
73f555e to
cf8ca37
Compare
No description provided.