18.0 tutorial nire #816

nire-odoo · 2025-06-18T07:08:27Z

No description provided.

robodoo · 2025-06-18T07:08:30Z

bso-odoo

Here are a few cosmetic comments.

bso-odoo · 2025-06-18T07:24:17Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


We try to always include the return character at the end of the last line in every file.
This way, when a new line is added later, the diff will not impact this previously last line.

estate/models/estate_property.py

bso-odoo · 2025-06-18T07:27:18Z

estate/__manifest__.py

@@ -6,6 +6,9 @@
    # 'version': '18.0',
    'author': 'Nicolas Renard',
    'data': [
+        'views/estate_property_views.xml',
+        'views/estate_menus.xml',
+        'security/ir.model.access.csv'


In arrays, lists, sets, dictionaries, objects... we include a , comma after the last entry too.
This way, if a new entry is added, the line will not be part of the diff.

bso-odoo

Here are a few comments:

bso-odoo · 2025-06-18T13:12:57Z

estate/__init__.py

-from . import models
+from . import models


Let's take this opportunity to train using git: try to apply such changes directly within the commit where the line was introduced.
You can use the git rebase -i command to rewrite the history on your local branch, then you'll need to use git push --force-with-lease to send sush changes to the repo. (Try not to use git push --force to avoid accidents when you'll work with other people on a common branch)

bso-odoo · 2025-06-18T13:15:11Z

estate/models/estate_property_type.py

+
+    name = fields.Char("Name",required=True)
+
+


Funny... this line shows empty lines at the end... but somehow says that it does not end with a return. >_<

I guess there are spaces on it.

bso-odoo · 2025-06-18T13:15:31Z

estate/security/ir.model.access.csv

+access_estate_property_type,estate_property_type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_tag,estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1
+access_estate_property_offer,estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1


Return on last line also on XML and CSV.

bso-odoo

Here are a few comments.
You can also try to adapt your commit messages in order to match the commit guidelines.

estate/models/estate_property.py

bso-odoo · 2025-06-19T09:12:49Z

estate/models/estate_property.py

-    living_area = fields.Integer("Living area")
+    living_area = fields.Integer("Living area (sqm)")
    facades = fields.Integer("Facades")
    garage = fields.Boolean("Garage")
    garden = fields.Boolean("Garden")
    garden_area = fields.Integer("Garden area")
    garden_orientation = fields.Selection(
        string='Garden orientation',
-        selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')],
+        selection=[('north', "North"), ('south', "South"), ('east', "East"), ('west', "West")],
        help="This Type is used to tell the garden orientation for a property"
        )
    active = fields.Boolean("Active",default=True)
    state = fields.Selection(
        string='State',
-        selection=[('new', 'New'), ('offer_received', 'Offer received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Canceled')],
+        selection=[('new', "New"), ('offer_received', "Offer received"), ('offer_accepted', "Offer Accepted"), ('sold', "Sold"), ('cancelled', "Canceled")],


Try to do such changes in the commit where they initially appeared.

bso-odoo · 2025-06-19T09:13:22Z

estate/models/estate_property_type.py

+
+    name = fields.Char("Name",required=True)
+
+


I guess there are spaces on it.

bso-odoo

Here are some comments.
Note that you still have some files that do not have a return on their last line.

bso-odoo · 2025-06-23T06:55:49Z

estate/views/estate_tag_list_view.xml

+        <field name="name">estate.tag.list.view</field>
+        <field name="model">estate.property.tag</field>
+        <field name="arch" type="xml">
+            <list string="Tests" editable='top'>


We use " around attribute values in XML

bso-odoo · 2025-06-23T06:56:39Z

estate/models/estate_property.py

+    def _unlink_except_new_or_cancelled(self):
+        for property in self:
+            if property.state == 'new' or property.state == 'cancelled':
+                raise UserError("Can't delete a property that is new or cancelled!")


Those strings are not implicitly translated, you have to explicitly call _ (from odoo import _)

bso-odoo · 2025-06-26T09:33:29Z

awesome_dashboard/static/src/dashboard/pie_chart/pie_chart.js

+        onWillUpdateProps(() => {
+            this.chart.destroy()
+            this.renderChart()
+        })


At this point, this.props still contains the old props. (Therefore the name "on WILL update")
onWillUpdateProps((props) => {...}) receives the new props as parameter.
You most likely want the render to use the most recent ones, instead of the old ones.

bso-odoo reviewed Jun 18, 2025

View reviewed changes

nire-odoo force-pushed the 18.0-tutorial-nire branch 2 times, most recently from c09b8c2 to 43cf3f3 Compare June 19, 2025 07:53

bso-odoo reviewed Jun 19, 2025

View reviewed changes

bso-odoo reviewed Jun 23, 2025

View reviewed changes

nire-odoo added 16 commits June 26, 2025 09:37

[ADD] initial commit

66b1c3a

[ADD] Chapter 3 super modifié

28bb608

[ADD] chapter 4 and 5

b9f198c

[ADD] Chapter 6

a5deba5

[ADD] Chapter 7

674da49

[ADD] Chapter 7.1

da60e72

[ADD] Chapter 8

2e90538

[ADD] Chapter 9

84a4fed

[ADD] Chapter 10

32412bb

[ADD] Chapter 11: Add The Sprinkles

bc41f88

[ADD] Chapter 12 : Inheritance

dd90eec

[ADD] Chapter 13 : Interact with other modules

1286000

[ADD] Chapter 14 : Kanban !

3901768

[ADD] Chapter 1 : OWL Components

478bd11

[ADD] Chapter 2 (2.1->2.8) : Build a dashboard

347605d

[ADD] Chapter 2 (2.8 -> 2.11)

0a3f6d0

nire-odoo force-pushed the 18.0-tutorial-nire branch 3 times, most recently from 745271b to c49701b Compare June 26, 2025 08:12

[FIX] Fixing ruff

e0c81e2

nire-odoo force-pushed the 18.0-tutorial-nire branch from c49701b to e0c81e2 Compare June 26, 2025 08:27

bso-odoo reviewed Jun 26, 2025

View reviewed changes

[ADD] Unit test

d2bc9b0

nire-odoo force-pushed the 18.0-tutorial-nire branch from 9b9bc86 to d2bc9b0 Compare June 30, 2025 09:30

		from . import models No newline at end of file
		from . import models

18.0 tutorial nire #816

Are you sure you want to change the base?

18.0 tutorial nire #816

Uh oh!

Conversation

nire-odoo commented Jun 18, 2025

Uh oh!

robodoo commented Jun 18, 2025

Uh oh!

bso-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bso-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bso-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bso-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!