18.0 real estate module shzi #820

shzi-odoo · 2025-06-18T12:40:26Z

No description provided.

…tegrate it with the database

… default home page + add basic ui for the property so I can manage them easily

robodoo · 2025-06-18T12:40:29Z

…e relational database

… onchange use

task-#######

…ce usability

aboo-odoo

Hey! Good job for this PR, I've been extra picky but again 🎉

A few generic comments:

A lot of your IDE stuff is in the diff, you need to remove that
Could you add a description to the PR and change the PR title according to the guideline [XYZ] module: short desc. like for a commit message link
Usually, you'll want one commit / task to keep the chain of commits as clean and small as possible. As here, the task is to create the module Estate, it should be the one commit on your branch. Could you squash your commits into 1 ?

aboo-odoo · 2025-06-23T08:02:59Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


Always add an EOL character at the end of your files to minimize the diffs of the next dev updating the file 👍

aboo-odoo · 2025-06-23T08:03:50Z

estate/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    'name': 'Estate',


In python, for quoting strings we try to follow the following convention:

single quote ' around technical terms
double quotes " around display terms

=> ('north', "North")

Let's try to follow this during this tutorial, even though you'll find many counter examples in the existing code.

aboo-odoo · 2025-06-23T08:04:18Z

estate/models/estate_property.py

@@ -0,0 +1,110 @@
+from odoo import fields, models, api


The imports should be

External libraries (one per line sorted and split in python stdlib)

Imports of odoo

Imports from Odoo modules (rarely, and only if necessary)

Inside these 3 groups, the imported lines are alphabetically sorted. You can use RUFF to help you sort them, it's quite handy

aboo-odoo · 2025-06-23T08:05:01Z

estate/models/estate_property.py

+    _name = "estate.property"
+    _description = "Store Real Estate Properties"
+
+    name = fields.Char("Estate Name", required=True, translate=True)


What do you think the translate=True here ?

aboo-odoo · 2025-06-23T08:05:52Z

estate/models/estate_property.py

+    name = fields.Char("Estate Name", required=True, translate=True)
+    description = fields.Text("Description", help="Enter the real estate item description")
+    postcode = fields.Char("Postcode")
+    date_availability = fields.Date("Available From", copy=False, default=lambda self: date.today() + timedelta(days=90))


timedelta(days=90)) is not exactly 3 months ahah

aboo-odoo · 2025-06-23T09:02:51Z

estate/models/estate_property_offer.py

+    date_deadline = fields.Datetime(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
+
+    # Computed functions
+    @api.depends('create_date', 'validity')


Suggested change

@api.depends('create_date', 'validity')

@api.depends('validity')

create_date will never change, only place variable that change to trigger the re-compute of the method

aboo-odoo · 2025-06-23T09:23:34Z

estate/models/estate_property_offer.py

+            if offer.property_id.buyer_id:
+                raise UserError("An offer has already been accepted for this property.")


I would rather

Suggested change

if offer.property_id.buyer_id:

raise UserError("An offer has already been accepted for this property.")

if offer.property_id.state == 'offer_accepted':

raise UserError("An offer has already been accepted for this property.")

Because the fact there is a buyer id does not mean an offer has been accepted (conceptually speaking)

aboo-odoo · 2025-06-23T09:24:02Z

estate/models/estate_property_offer.py

Again, file order is important

aboo-odoo · 2025-06-23T09:24:58Z

estate/views/estate_property_offer_views.xml

+            </list>
+        </field>
+    </record>
+</odoo>


Not writing it on every file, but all are missing the EOL character

aboo-odoo · 2025-06-23T09:26:16Z

estate/views/estate_property_offer_views.xml

+                <field name="partner_id" />
+                <field name="status" />
+                <button name="action_accept_offer" string="Confirm"  type="object" icon="fa-check"/>
+                <button name="action_refuse_offer" string="Cancel" type="object" icon="fa-times"/>


Your buttons are always shown, wouldn't it be better to hide them once they have been accepted or refused ?

…crosss modules + restrictions

aboo-odoo

Hey! Final review on the python part, it focuses on functionality, not style anymore 😄 All and all, an extremely good PR, well done 👍

On Monday, I'll teach you how to remove the .idea stuff, squash your commits and rebase your branch to have it all nice and clean.

By then, try to get your runbot green 🟢 and fix the comments from last time and this review please 👍

aboo-odoo · 2025-06-27T14:21:48Z

estate/models/__init__.py

+from . import (estate_property, estate_property_offer, estate_property_tag,
+               estate_property_type, inherited_res_users)


Use several lines, it's easier to manage in the future

aboo-odoo · 2025-06-27T14:25:36Z

estate/models/estate_property_offer.py

+    @api.model
+    def create(self, vals):


Very nice and robust method override but it'd be even better if you could do it in batch to increase performances.

Suggested change

@api.model

def create(self, vals):

@api.model_create_multi

def create(self, vals_list):

for vals in vals_list:

# Do things

return super().create(vals_list)

aboo-odoo · 2025-06-27T14:26:50Z

estate/models/estate_property_offer.py

+            other_offers = offer.property_id.offer_ids - offer
+            other_offers.write({"status": "refused"})


Very nice use of recordset!!!

…ity to try and fix prod issue

shzi-odoo added 3 commits June 17, 2025 16:15

Create the real estate module for properties and add the model and in…

4f34e82

…tegrate it with the database

Add security file and declare it inside the manifest file

d3eea49

Insert the basic ui needed for the application to be displayed in the…

49bd188

… default home page + add basic ui for the property so I can manage them easily

shzi-odoo and others added 5 commits June 18, 2025 17:47

Adjust the views and models to match ch 7 functionalities to integrat…

7c55a43

…e relational database

Add computed fields implementation for direct use and inverse use and…

75aa4f0

… onchange use

[ADD] estate: Add a special mention section

663c22e

task-#######

Adusted the constraints for python and SQL and added buttons to enhan…

54fe6ef

…ce usability

Add note field

0cc2e66

aboo-odoo reviewed Jun 23, 2025

View reviewed changes

shzi-odoo added 2 commits June 24, 2025 13:41

Finish python 101 tutorial implemenitng kanban views + sharing data a…

70e4584

…crosss modules + restrictions

initiated basic owl components for tutorial

44d64cd

aboo-odoo reviewed Jun 27, 2025

View reviewed changes

shzi-odoo added 3 commits June 30, 2025 13:35

Finish implementation of awesome dashboard with js

892661c

Fix runbot errors trial #1

917662c

Change the property offer view mode to a tree form to keep functional…

8d24d6b

…ity to try and fix prod issue

	@api.depends('create_date', 'validity')
	@api.depends('validity')

		if offer.property_id.buyer_id:
		raise UserError("An offer has already been accepted for this property.")

		from . import (estate_property, estate_property_offer, estate_property_tag,
		estate_property_type, inherited_res_users)

-    @api.model
-    def create(self, vals):
+    @api.model_create_multi
+        def create(self, vals_list):
+            for vals in vals_list:
+                # Do things
+            return super().create(vals_list)

		other_offers = offer.property_id.offer_ids - offer
		other_offers.write({"status": "refused"})

18.0 real estate module shzi #820

Are you sure you want to change the base?

18.0 real estate module shzi #820

Uh oh!

Conversation

shzi-odoo commented Jun 18, 2025

Uh oh!

robodoo commented Jun 18, 2025

Uh oh!

aboo-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aboo-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!