Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Accumulator Updates #5760

Closed
wants to merge 1 commit into from
Closed

Simplify Accumulator Updates #5760

wants to merge 1 commit into from

Conversation

xu-shawn
Copy link
Contributor

@xu-shawn xu-shawn commented Jan 11, 2025 •
edited
Loading

After #5759 accumulator updates are strictly on a per-move basis. Therefore, the generic code for updating multiple moves at once is no longer needed.

Passed Non-regression STC:
LLR: 3.00 (-2.94,2.94) <-1.75,0.25>
Total: 81696 W: 21204 L: 21039 D: 39453
Ptnml(0-2): 210, 8431, 23416, 8566, 225
https://tests.stockfishchess.org/tests/view/67823a24a31c4c13e83518a8

no functional change

@vondele
Copy link
Member

vondele commented Jan 11, 2025

missing link to https://tests.stockfishchess.org/tests/view/67823a24a31c4c13e83518a8

@Disservin Disservin added the simplification A simplification patch label Jan 11, 2025
@xu-shawn
Copy link
Contributor Author

Ryzen 5 7600X

sf_base =  1869972 +/-   5572 (95%)
sf_test =  1871071 +/-   5603 (95%)
diff    =     1098 +/-   3357 (95%)
speedup = 0.05877% +/- 0.180% (95%)

@Disservin Disservin added to be merged Will be merged shortly and removed to be merged Will be merged shortly labels Jan 12, 2025
@Disservin
Copy link
Member

mh wanted to merge this but dunno overlooked it, can you rebase for next merge please?

@xu-shawn xu-shawn force-pushed the test963 branch 2 times, most recently from 63d453b to 540092c Compare January 12, 2025 20:56
@xu-shawn
simplify accumulator updates
069c902 
no functional change
@vondele vondele added the to be merged Will be merged shortly label Jan 25, 2025
@vondele vondele closed this in 62ecdfe Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstembera mstembera mstembera left review comments

Assignees
No one assigned
Labels
simplification A simplification patch to be merged Will be merged shortly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xu-shawn @vondele @Disservin @mstembera