Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pack reordering #5802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xu-shawn
Copy link
Contributor

@xu-shawn xu-shawn commented Jan 19, 2025

Supersedes #5782. This implementation has been refactored following @Sopel97's review.

no functional change

Copy link

github-actions bot commented Jan 19, 2025

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 12857312130 / attempt 1)

no functional change
@xu-shawn xu-shawn force-pushed the cleanup_pack_ordering_3 branch from bab6dfc to 7321af2 Compare January 19, 2025 03:14
Copy link
Member

@Sopel97 Sopel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean now, I like it

src/nnue/nnue_feature_transformer.h Outdated Show resolved Hide resolved
no functional change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants