fixed location encounter bug

[DraKen0009]

Proposed Changes

• location with deleted encounter were not updating their current_encounter , causing bug

Associated Issue

-Fixes ohcnetwork/care_fe#10909

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Summary by CodeRabbit

• Bug Fixes

  • Enhanced the processing of encounter completions so that all related updates occur simultaneously, ensuring that all active associations are properly cleared when an encounter is finalized.

• Tests

  • Augmented validations to confirm that facility records no longer show ongoing encounters once an encounter is completed.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR enhances the transactional integrity of the encounter handling logic. The function close_related_location_from_encounter now wraps updates in a transaction block and additionally clears the current_encounter field on related FacilityLocation records. The corresponding test is updated to assert that the current_encounter is indeed cleared after an encounter is marked completed. No changes were made to public or exported entities.

Changes

File	Summary
care/emr/api/…/location.py	Updates close_related_location_from_encounter to use transaction.atomic(), clearing current_encounter of FacilityLocation and marking related FacilityLocationEncounter objects as completed.
care/emr/tests/…/test_location_api.py	Adds an assertion to verify that current_encounter is cleared after encounter completion; includes minor formatting adjustments.

Sequence Diagram(s)

sequenceDiagram
    participant E as Encounter Object
    participant L as FacilityLocation
    participant LE as FacilityLocationEncounter
    participant TX as Transaction Block

    E->>+TX: Trigger close_related_location_from_encounter
    TX->>L: Set current_encounter to None
    TX->>LE: Update end_datetime and status for non-completed encounters
    TX-->>-E: Commit transaction and finish update

Loading

Possibly related PRs

• mark Encounter location as completed once Encounter is completed and more #2869: Directly modifies the use of close_related_location_from_encounter in the EncounterViewSet, relating strongly to these transactional logic changes.
• Adding Test cases for Location Viewset #2818: Adjusts validation logic around end_datetime and status handling for related models, indirectly connected to the encounter disassociation improvements.

Suggested reviewers

• vigneshhari

Poem

In the realm of code, a change unfolds,
Transaction magic ensuring no loose holds.
With clear disassociations, the encounters say adieu,
And tests now confirm what we always knew.
A subtle shift in logic, so precise and neat,
Cheers to safer code and victories discreet!
🌟 Happy coding!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 039292f and d1a7fae.

📒 Files selected for processing (2)

• care/emr/api/viewsets/location.py (1 hunks)
• care/emr/tests/test_location_api.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Test / Test
• GitHub Check: Analyze (python)

🔇 Additional comments (2)

care/emr/tests/test_location_api.py (1)

1058-1063: Test enhancement looks good, but maybe add a comment explaining why?

The added assertion correctly verifies that the location's current_encounter is set to None after an encounter is completed, which is the key behavior we're fixing. This ensures our fix works as expected.

care/emr/api/viewsets/location.py (1)

441-453: Good use of transaction.atomic() for data consistency.

The modified function now properly ensures that both operations (clearing the current_encounter field and updating the location encounters) are performed atomically. This prevents potential data inconsistencies that could occur if one operation succeeded but the other failed.

The core bug fix is implemented by adding the FacilityLocation update operation to clear the current_encounter field when an encounter is completed, which addresses the issue described in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.28%. Comparing base (039292f) to head (d1a7fae).

Files with missing lines	Patch %	Lines
care/emr/api/viewsets/location.py	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2882      +/-   ##
===========================================
- Coverage    56.29%   56.28%   -0.01%     
===========================================
  Files          226      226              
  Lines        10978    10979       +1     
  Branches      1117     1117              
===========================================
  Hits          6180     6180              
- Misses        4781     4782       +1     
  Partials        17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.