Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node & Ubuntu versions #2439

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Update Node & Ubuntu versions #2439

merged 5 commits into from
Nov 30, 2024

Conversation

corrideat
Copy link
Member

Update Node from 18 to 22 as 18 will reach EOL in about 6 months.
Update Ubuntu from 20.04 to 24.04 as it'll also reach EOL in about in 4 months.

Copy link

cypress bot commented Nov 28, 2024

group-income    Run #3463

Run Properties:  status check passed Passed #3463  •  git commit 9e102819a4 ℹ️: Merge fc394b095fe1ef122ed2f453422f9d72af72d333 into 4464feab187308af2cfeefa6a73e...
Project group-income
Branch Review update-ci-environment
Run status status check passed Passed #3463
Run duration 08m 51s
Commit git commit 9e102819a4 ℹ️: Merge fc394b095fe1ef122ed2f453422f9d72af72d333 into 4464feab187308af2cfeefa6a73e...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎

@corrideat
Copy link
Member Author

Tests are passing, but they failed here with some weird error I hadn't seen before about being unable to call fetch: https://github.com/okTurtles/group-income/actions/runs/12069779976.

Copy link
Collaborator

@SebinSong SebinSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@taoeffect taoeffect merged commit 053a819 into master Nov 30, 2024
4 checks passed
@taoeffect taoeffect deleted the update-ci-environment branch November 30, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants