-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send email endpoint #37
Conversation
01c6972
to
a5ffc55
Compare
I'm setting up the environment to take a look at this |
As we discussed, we found it better to maintain #33 open and remove the remote elasticsearch features from this PR. |
a5ffc55
to
9029633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the modifications! Now I could focus on some aspects that I couldn't before, I think these should be my final requests :)
1c1cdcc
to
2c396d4
Compare
reset some files fix api fixes set required fields fix prefix properties name rename change subject and title fix test fix test rename from SuggestionService to SuggestionServiceInterface test create_suggestion_service implements api tests
a3f9d4c
to
5fd1370
Compare
Have you test this PR with actual Mailjet credentials? |
Yes, I created a new account (personal) and tested. Do you want some help to do that? |
Co-authored-by: José Guilherme Vanz (a.k.a galináceo) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #23
@jvanz @giuliocc
Changes
POST /suggestions
config/sample.env
fileconfig/current.env
)Test
200 OK