Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jwt.py #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update jwt.py #434

wants to merge 1 commit into from

Conversation

gabrielsroka
Copy link
Contributor

60 minutes is too long and causes error #382

60 minutes is too long and causes error okta#382
@gabrielsroka
Copy link
Contributor Author

gabrielsroka commented Feb 12, 2025

it seems like an obvious fix (and a minor one: change 60 to 59):

CLA may not be required if the contribution(s) are minor enough not to be considered intellectual property

pls don't make ppl who are trying to help jump thru unnecessary time-wasting hoops. i not only found the issue, reported it, but i also found a workaround and submitted a PR

@bretterer
Copy link
Collaborator

@gabrielsroka

pls don't make ppl who are trying to help jump thru unnecessary time-wasting hoops. i not only found the issue, reported it, but i also found a workaround and submitted a PR

These are not unnecessary time-wasting hoops. Additionally, no one has stated you need a CLA yet for this change. This is a legal requirement for our 3rd party submissions for fixes.

@okta okta deleted a comment from gabrielsroka Feb 25, 2025
@okta okta deleted a comment from gabrielsroka Feb 25, 2025
@okta okta locked as too heated and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants