Give feedback to users with invalid regex in pattern (#444)

oleeskild · Sep 30, 2023 · b4a1845 · b4a1845
1 parent 69333d5
commit b4a1845
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "digitalgarden",
 	"name": "Digital Garden",
-	"version": "2.49.0",
+	"version": "2.49.1",
 	"minAppVersion": "0.12.0",
 	"description": "Publish your notes to the web for others to enjoy. For free.",
 	"author": "Ole Eskild Steensen",

diff --git a/src/compiler/GardenPageCompiler.ts b/src/compiler/GardenPageCompiler.ts
@@ -104,10 +104,20 @@ export class GardenPageCompiler {
 
 	async convertCustomFilters(text: string) {
 		for (const filter of this.settings.customFilters) {
-			text = text.replace(
-				RegExp(filter.pattern, filter.flags),
-				filter.replace,
-			);
+			try {
+				text = text.replace(
+					RegExp(filter.pattern, filter.flags),
+					filter.replace,
+				);
+			} catch (e) {
+				Logger.error(
+					`Invalid regex: ${filter.pattern} ${filter.flags}`,
+				);
+
+				new Notice(
+					`Your custom filters contains an invalid regex: ${filter.pattern}. Skipping it.`,
+				);
+			}
 		}
 
 		return text;

diff --git a/versions.json b/versions.json
@@ -1,4 +1,5 @@
 {
+	"2.49.1": "0.12.0",
 	"2.49.0": "0.12.0",
 	"2.48.0": "0.12.0",
 	"2.47.0": "0.12.0",