-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images, colors, pdf export & more #47
Open
Ethran
wants to merge
117
commits into
olup:main
Choose a base branch
from
Ethran:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Export to png and pdf both + Intent to open notable:// links in the app from obsidian or anywhere as floating window + Updated gradle version as well
Book navigation is breaking when trying to switch to other pages though
Using mainactivity means that we can open a book, we can do anything along the app and come back to obsidian when we press back. We will automatically be exporting what we started with as well
testing changes
readme adding supported divices
…png, just allow to share?
# Conflicts: # app/src/main/java/com/olup/notable/db/Kv.kt
before I break something
added Note Max to supported device table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
Sorry for not splitting this into smaller fixes, but I noticed there hasn't been much development on this repo, so I made improvements on my own to better fit my needs. I can confirm that it works on the Boox Note Air 4C running Android 13. I will periodically add changes and improvements to my fork, likely small adjustments to address things that annoy me while using the app (as with the changes mentioned above).