Fix broken core on darwin #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue on macOS where the AVX2 insruction set for x86_64 cannot be properly emulated on docker containters on darwinOS. See: docker/for-mac#6620 for details The rust lib was compiled without the vectorized optimizations and this commit updates this file as well as the cmake files/
omeryusufyagci
added
platform
core
omeryusufyagci
added a commit
that referenced
this pull request
Dec 7, 2024
…86) This PR fixes #84 by providing a separate release for arm macOS machines. The underlying problem was determined to be a known (not to us, at the time) limitation of the QEMU-based Docker emulation on these machines. See: docker/for-mac#6620 for details with similar issues. This completes the work started by #85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses compatibility issues on Apple Silicon macOS machines when using Docker to emulate x86_64. The issue arose due to the
libdf.sobeing compiled with AVX2 instructions for x86_64, which are apparently not supported by Docker's QEMU-based emulation on these systems. See the related discussion here for details.Unfortunately, the QEMU limitation is still here, and removing this optimization from the library fixed this issue for us.
Additionally few minor updates to core, to fix a deprecation error with clang and a few other warnings.