✨ ClaimIssuer factory #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for the contracts deployed by the factory, it should be upgradeable proxies, pointing to an initial implementation (ours) but letting the contract owner change implementation (every claim issuer could have their own implementation to verify claims differently). we could use create3 to make sure the addresses are the same on every chain even if we update the reference implem later on. |
|
|
||
| address public implementation; | ||
| mapping(address => address) public deployedClaimIssuers; |
There was a problem hiding this comment.
Lint issue here to correct about order of functions, other than that the contract looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.