Update Power CTS consisting of deprecated Power properties related fields #189
Conversation
…elds Related-To: VLCLJ-2413 Signed-off-by: Anvesh Bakwad <[email protected]>
anvesh-intel
requested review from
AshwinKumarKulkarni,
jitendrasharma1989,
bellekal and
shubskmr
There was a problem hiding this comment.
We should just remove the below check in CTS GivenValidPowerHandleWhenRequestingPowerLimitsThenExpectZesSysmanPowerGetLimitsToReturnValidPowerLimits
EXPECT_LE(pPeak.powerAC, pProperties.maxLimit);
Since min/max/default is still being supported in driver code when KMD supports it, lets not remove all tests related to it.
| @@ -1002,102 +947,6 @@ TEST_F( | |||
| } | |||
| } | |||
|
|
|||
| TEST_F( | |||
There was a problem hiding this comment.
Why is this being removed? This test validates if kmd is sanitizing upper limits properly according to h/w limits.
| EXPECT_EQ(pproperties_initial.maxLimit, pproperties_later.maxLimit); | ||
| EXPECT_EQ(pproperties_initial.minLimit, pproperties_later.minLimit); | ||
| EXPECT_EQ(pproperties_initial.defaultLimit, | ||
| pproperties_later.defaultLimit); |
There was a problem hiding this comment.
This check should be okay, since we are still supporting min/max/default limits if KMD supports it. If its supported they should be same between 2 calls which is checked here.
| @@ -84,41 +84,6 @@ TEST_F( | |||
| } | |||
| } | |||
| } | |||
| TEST_F( | |||
There was a problem hiding this comment.
Is this test failing? Why is this being removed?
We should just remove the below check in CTS GivenValidPowerHandleWhenRequestingPowerLimitsThenExpectZesSysmanPowerGetLimitsToReturnValidPowerLimits
EXPECT_LE(pPeak.powerAC, pProperties.maxLimit);
…elds Related-To: VLCLJ-2413 Signed-off-by: Anvesh Bakwad <[email protected]>
Related-To: VLCLJ-2413
Signed-off-by: Anvesh Bakwad [email protected]