Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xe: reduction: fixup exceptions on zero dims #2469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Simonsays095
Copy link
Contributor

@Simonsays095 Simonsays095 commented Jan 21, 2025

Fixes MFDNN-13039. Reduction gtests were enabled on the GPU in #2243, which revealed floating point exceptions when dividing by zero:

$ ctest -R test_reduction_gpu
Test project oneDNN/build
    Start 209: test_reduction_gpu
1/1 Test #209: test_reduction_gpu ...............***Exception: Numerical  0.31 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.32 sec

The following tests FAILED:
        209 - test_reduction_gpu (NUMERICAL)
Errors while running CTest

These errors are fixed by adding appropriate short-circuit checks to skip most logic (and execution) when a zero-dim is present.

@Simonsays095 Simonsays095 requested review from a team as code owners January 21, 2025 22:08
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Jan 21, 2025
@Simonsays095
Copy link
Contributor Author

make test
disable test_device_cpu
enable test_device_gpu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants