Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xe, benchdnn: fix large buffer ip and add nighly gpu tests #2573

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rjoursler
Copy link
Contributor

@rjoursler rjoursler commented Jan 31, 2025

Adds large buffer IP tests.

The main IP implementations rely on GEMM and convolution, so correctness is largely handled by previous work. The remaining work in this PR is to the offset arithmetic in the reference convolution and to remove an unuse implementation.

Sample run summary on PVC (the one failure is due to a runtime bug):

tests:26 passed:25 skipped:0 mistrusted:0 unimplemented:0 invalid_arguments:0 failed:1 listed:0
total: 514.01s; fill: 152.07s (30%); compute_ref: 116.66s (23%); compare: 165.29s (32%);

@rjoursler rjoursler requested review from a team as code owners January 31, 2025 18:57
@github-actions github-actions bot added documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel component:tests Codeowner: @oneapi-src/onednn-arch labels Jan 31, 2025
@rjoursler rjoursler force-pushed the rjoursle/large_buffer_ip branch from ee8c478 to 0ed0070 Compare January 31, 2025 18:58
@github-actions github-actions bot removed the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Jan 31, 2025
@rjoursler
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_ip
set test_scope=nightly

@rjoursler rjoursler force-pushed the rjoursle/large_buffer_ip branch from 0ed0070 to 9f3cc17 Compare January 31, 2025 20:54
@rjoursler
Copy link
Contributor Author

make test
disable device_cpu
disable benchdnn_all
enable benchdnn_ip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests Codeowner: @oneapi-src/onednn-arch platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants