Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of num_compute_units query for device info #2525

Merged
merged 11 commits into from
Jan 28, 2025

Conversation

dyniols
Copy link
Contributor

@dyniols dyniols commented Jan 7, 2025

This change introduces new enumerator for enum ur_device_info_t with name UR_DEVICE_INFO_NUM_COMPUTE_UNITS to get number of compute units for different combinations of device and backend.
It's needed for extension sycl_ext_oneapi_num_compute_units https://github.com/Pennycook/llvm/blob/100b35b47bc6e35f3cf0bcc3c185df854d4da9c9/sycl/doc/extensions/proposed/sycl_ext_oneapi_num_compute_units.asciidoc

intel/llvm#16538

@dyniols dyniols marked this pull request as ready for review January 7, 2025 13:57
@dyniols dyniols requested review from a team as code owners January 7, 2025 13:57
@dyniols dyniols requested a review from npmiller January 7, 2025 13:57
include/ur_api.h Outdated Show resolved Hide resolved
@aarongreig
Copy link
Contributor

please also update our urDeviceGetInfo conformance test with the new enum https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/device/urDeviceGetInfo.cpp#L126

@dyniols dyniols requested a review from aarongreig January 8, 2025 11:22
@dyniols
Copy link
Contributor Author

dyniols commented Jan 8, 2025

please also update our urDeviceGetInfo conformance test with the new enum https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/device/urDeviceGetInfo.cpp#L126

Done

Copy link
Contributor

@aarongreig aarongreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need a tag update PR in the LLVM repo as well, like this https://github.com/intel/llvm/pull/16572/files

@dyniols
Copy link
Contributor Author

dyniols commented Jan 14, 2025

you'll need a tag update PR in the LLVM repo as well, like this https://github.com/intel/llvm/pull/16572/files

Could you check if I got this right? Thanks!

@aarongreig
Copy link
Contributor

you'll need a tag update PR in the LLVM repo as well, like this https://github.com/intel/llvm/pull/16572/files

Could you check if I got this right? Thanks!

yeah that looks correct, just going to link it here for future reference intel/llvm#16538

once this PR is merged a UR maintainer will update the tag for you and get the LLVM PR merged

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA and HIP LGTM!

@steffenlarsen
Copy link
Contributor

@oneapi-src/unified-runtime-level-zero-write & @oneapi-src/unified-runtime-native-cpu-write - Friendly ping on behalf of @dyniols .

Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, sorry for the late review

@dyniols
Copy link
Contributor Author

dyniols commented Jan 22, 2025

@npmiller @oneapi-src/unified-runtime-level-zero-write - Friendly ping requesting review

Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarongreig aarongreig added the ready to merge Added to PR's which are ready to merge label Jan 27, 2025
@kbenzie kbenzie added conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Jan 27, 2025
@kbenzie kbenzie merged commit 902bb2e into oneapi-src:main Jan 28, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants