Remove command-buffer command handle ref counting #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
be8b4fc to
ef1de22
Compare
EwanC
added a commit
to EwanC/llvm
that referenced
this pull request
Jan 17, 2025
Reflects UR change from oneapi-src/unified-runtime#2578 where we no longer need to manually manage the lifetimes of the individual commands in a UR command-buffer.
EwanC
added a commit
to EwanC/llvm
that referenced
this pull request
Jan 17, 2025
Reflects UR change from oneapi-src/unified-runtime#2578 where we no longer need to manually manage the lifetimes of the individual commands in a UR command-buffer.
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
ef1de22 to
460eac2
Compare
aarongreig
approved these changes
Jan 22, 2025
fabiomestre
reviewed
Jan 22, 2025
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
460eac2 to
49fb7a9
Compare
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
49fb7a9 to
924569c
Compare
fabiomestre
approved these changes
Jan 22, 2025
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
924569c to
eb23fe5
Compare
|
ping @oneapi-src/unified-runtime-native-cpu-write & @oneapi-src/unified-runtime-level-zero-write for review |
hvdijk
approved these changes
Jan 24, 2025
pbalcer
approved these changes
Jan 27, 2025
|
@EwanC please pull in the changes from main branch and run |
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
eb23fe5 to
7fba037
Compare
The handles to individual commands returned from command-buffer append entry-points currently need reference counted by the user. However this isn't a model that maps to OpenCL/CUDA/HIP/Level-Zero where the lifetime of commands is tied to the lifetime of the parent command-buffer/graph/command-list. Remove this idiom from the command-buffer UR API, adapters, and CTS. The APIs that are removed are * `urCommandBufferCommandGetInfoExp` * `urCommandBufferReleaseCommandExp` * `urCommandBufferRetainCommandExp`
EwanC
force-pushed
the
ewan/remove_command_ref_counting
branch
from
7fba037 to
df1de2d
Compare
Done, thanks for the heads-up on the conflict |
EwanC
added a commit
to EwanC/llvm
that referenced
this pull request
Jan 29, 2025
Reflects UR change from oneapi-src/unified-runtime#2578 where we no longer need to manually manage the lifetimes of the individual commands in a UR command-buffer.
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 29, 2025
Reflects UR change from oneapi-src/unified-runtime#2578 where we no longer need to manually manage the lifetimes of the individual commands in a UR command-buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handles to individual commands returned from command-buffer append entry-points currently need reference counted by the user. However this isn't a model that maps to OpenCL/CUDA/HIP/Level-Zero where the lifetime of commands is tied to the lifetime of the parent command-buffer/graph/command-list.
Remove this idiom from the command-buffer UR API, adapters, and CTS. The APIs that are removed are:
urCommandBufferCommandGetInfoExpurCommandBufferReleaseCommandExpurCommandBufferRetainCommandExpDPC++ PR - intel/llvm#16670