dir permissions fixed, now are octal

onmoon · Apr 9, 2021 · 6793b49 · 6793b49
1 parent 0505f41
commit 6793b49
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/CodeGenerator/Filesystem/FilePutContentsFileWriter.php b/src/CodeGenerator/Filesystem/FilePutContentsFileWriter.php
@@ -4,6 +4,7 @@
 
 namespace OnMoon\OpenApiServerBundle\CodeGenerator\Filesystem;
 
+use function intval;
 use function is_dir;
 use function Safe\file_put_contents;
 use function Safe\mkdir;
@@ -14,9 +15,9 @@ final class FilePutContentsFileWriter implements FileWriter
 {
     private int $dirPemissions;
 
-    public function __construct(int $dirPemissions)
+    public function __construct(string $dirPemissions)
     {
-        $this->dirPemissions = $dirPemissions;
+        $this->dirPemissions = intval($dirPemissions, 8);
     }
 
     public function write(string $path, string $filename, string $contents): void

diff --git a/test/functional/CodeGenerator/Filesystem/FilePutContentsFileWriterTest.php b/test/functional/CodeGenerator/Filesystem/FilePutContentsFileWriterTest.php
@@ -8,6 +8,8 @@
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\TestCase;
 
+use function decoct;
+use function fileperms;
 use function Safe\file_get_contents;
 use function Safe\rmdir;
 use function Safe\unlink;
@@ -26,14 +28,18 @@ public function testWriteCreatesFile(): void
         $fullPath    = $path . DIRECTORY_SEPARATOR . $filename;
         $fileContent = 'Some Random Content';
 
-        $fileWriter = new FilePutContentsFileWriter(0755);
+        $fileWriter = new FilePutContentsFileWriter('0755');
 
         Assert::assertFileDoesNotExist($fullPath);
         Assert::assertDirectoryDoesNotExist($path);
 
         $fileWriter->write($path, $filename, $fileContent);
 
         Assert::assertDirectoryExists($path);
+
+        /** @var int $permissions */
+        $permissions = fileperms($path);
+        Assert::assertSame('40755', decoct($permissions));
         Assert::assertFileExists($fullPath);
         Assert::assertEquals($fileContent, file_get_contents($fullPath));