Fixed minor fatal errors (#16)

* Added missing public declarations * Minor fix * Added ArrayDenormalizer for correct body handling
onmoon · Jan 26, 2020 · b36226f · b36226f
1 parent ef2eb32
commit b36226f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/CodeGenerator/Dto/PhpParserRootDtoFactory.php b/src/CodeGenerator/Dto/PhpParserRootDtoFactory.php
@@ -91,6 +91,7 @@ public function generateRootDto(
                     $this
                         ->factory
                         ->method('getPathParameters')
+                        ->makePublic()
                         ->setReturnType($pathParametersDtoClassName)
                         ->addStmt(new Return_(new Variable('this->pathParameters')))
                 );
@@ -120,6 +121,7 @@ public function generateRootDto(
                     $this
                         ->factory
                         ->method('getQueryParameters')
+                        ->makePublic()
                         ->setReturnType($queryParametersDtoClassName)
                         ->addStmt(new Return_(new Variable('this->queryParameters')))
                 );
@@ -138,6 +140,7 @@ public function generateRootDto(
                     $this
                         ->factory
                         ->method('getBody')
+                        ->makePublic()
                         ->setReturnType($requestBodyDtoClassName)
                         ->addStmt(new Return_(new Variable('this->body')))
                 );

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -39,11 +39,13 @@
             <argument key="$propertyTypeExtractor" type="service" id="Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor" />
         </service>
         <service id="Symfony\Component\Serializer\Normalizer\DateTimeNormalizer" />
+        <service id="Symfony\Component\Serializer\Normalizer\ArrayDenormalizer" />
         <service id="Symfony\Component\Serializer\Encoder\JsonEncoder" />
         <service id="openapi.bundle.serializer" class="Symfony\Component\Serializer\Serializer">
             <argument key="$normalizers" type="collection">
                 <argument type="service" id="Symfony\Component\Serializer\Normalizer\PropertyNormalizer" />
                 <argument type="service" id="Symfony\Component\Serializer\Normalizer\DateTimeNormalizer" />
+                <argument type="service" id="Symfony\Component\Serializer\Normalizer\ArrayDenormalizer" />
             </argument>
             <argument key="$encoders" type="collection">
                 <argument type="service" id="Symfony\Component\Serializer\Encoder\JsonEncoder" />

diff --git a/src/Serializer/ReflectionDtoSerializer.php b/src/Serializer/ReflectionDtoSerializer.php
@@ -119,7 +119,7 @@ private function setRequestBody(object $inputDto, ReflectionClass $inputDtoRefl,
         );
     }
 
-    private function getInputDtoFQCN(string $serviceInterface, string $methodName) : string
+    private function getInputDtoFQCN(string $serviceInterface, string $methodName) : ?string
     {
         $interfaceReflectionClass  = new ReflectionClass($serviceInterface);
         $method                    = $interfaceReflectionClass->getMethod($methodName);