Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for "huber" objective in the LGBM Booster #705

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

LukaszCmielowski
Copy link
Contributor

@LukaszCmielowski LukaszCmielowski commented Dec 19, 2024

Support for Booster with objectives other than "regression".

RuntimeError: LightGBM objective should be cleaned already not 'huber'.

pytest updated accordingly.

@LukaszCmielowski
Copy link
Contributor Author

@xadupre please take a look. Thx.

@xadupre
Copy link
Collaborator

xadupre commented Dec 19, 2024

It looks ok to me. You should sign your commits (git commit -s ...) to avoid the DCO issue. You can black . as well to fix the style issues then ruff check . to detect them.

@LukaszCmielowski
Copy link
Contributor Author

LukaszCmielowski commented Dec 19, 2024

Black & Ruff updated. Working on DCO ...

@LukaszCmielowski
Copy link
Contributor Author

@xadupre DCO fixed.

@LukaszCmielowski
Copy link
Contributor Author

@xadupre I see some checks (unrelated to this PR) failing due to xgb env issue:

XGBoost Library (libxgboost.dylib) could not be loaded

Let me know what are the next steps. Thanks.

@xadupre
Copy link
Collaborator

xadupre commented Dec 23, 2024

@xadupre I see some checks (unrelated to this PR) failing due to xgb env issue:

XGBoost Library (libxgboost.dylib) could not be loaded

Let me know what are the next steps. Thanks.

I fix CI. You need to update your branch to unlock you.

@LukaszCmielowski
Copy link
Contributor Author

@xadupre done.

@xadupre xadupre merged commit 0953819 into onnx:main Jan 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants