Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pylint github action file. #2332

Merged
merged 90 commits into from
Jun 11, 2024
Merged

Add pylint github action file. #2332

merged 90 commits into from
Jun 11, 2024

Conversation

fatcat-z
Copy link
Collaborator

@fatcat-z fatcat-z commented May 23, 2024 •
edited
Loading

Move all CI on Azure DevOps to GITHUB actions.

justinchuby
justinchuby reviewed May 30, 2024
View reviewed changes
.github/workflows/unit_test_matrix.yml Outdated
Comment on lines 55 to 60
- name: Run unit tests
run: pytest tests/

- name: Generate coverage report
if: ${{ matrix.report_coverage == 'True' }}
run: coverage report
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two steps can be combined. See https://github.com/onnx/onnx/blob/main/.github/workflows/main.yml

--cov-report=xml --cov-append --cov-branch --junit-xml pytest.xml

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need https://pypi.org/project/pytest-cov/

justinchuby
justinchuby reviewed May 30, 2024
View reviewed changes
.github/workflows/unit_test_matrix.yml Outdated
- name: Generate coverage report
if: ${{ matrix.report_coverage == 'True' }}
run: coverage report

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider uploading the coverage report to codecov: https://github.com/onnx/onnx/blob/093a8d335a66ea136eb1f16b3a1ce6237ee353ab/.github/workflows/main.yml#L144-L148

fatcat-z added 18 commits May 30, 2024 14:18
@fatcat-z
Add a new trigger for PR.
86f8450 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Remove invalid field.
e018b5a 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update code by pylint suggestions.
c02de62 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update code by pylint suggestions.
c4f9dcf 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Try main workflow.
ceb508b 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update setup.
2e1efd4 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update the call to setup.yml.
db24398 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update.
a1deb25 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update it.
2e9c83e 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update.
aa84994 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update checkout branch.
31153a5 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct the branch name.
410c9fe 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update correct branch.
ac8f9bf 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add a check for folder.
fd04a84 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update the call.
9cc1435 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Update the position of the call.
02d2d11 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add a trigger.
ccbd0e4 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Remove wrong statements.
a14008e 
Signed-off-by: Jay Zhang <[email protected]>
fatcat-z added 23 commits June 5, 2024 10:03
@fatcat-z
Correct the format.
5cfccdb 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Prepare final job.
7bd657c 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
This will only be triggered by a PR.
bd5f1ae 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add on push back.
3e2a2e9 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add unit test workflow.
0467444 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Lower the highest tf version to be tested.
5c2edd1 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add keras_application_tests core.
ece9a22 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct the path.
f6a8fc7 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add keras unit tests.
727fba0 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Remove unused files.
9ad022d 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Settle down protobuf version.
428c79d 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Install tf2onnx.
e8e7c00 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add keras unit tests on windows.
4dd9251 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Enable more windows tests.
8f48ae8 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct windows script.
3daec4d 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct windows tests.
0fc5f41 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Correct the environment variables in windows.
ec60ede 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Add more windows tests, and publish test results.
83219cb 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Make sure correct results were pusblished.
a7205d5 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Change the test result files path.
c33663d 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Check how to download test results.
870f22f 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Finalize the workflow actions.
1773e3f 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z
Remove azure pipelines.
f233bb1 
Signed-off-by: Jay Zhang <[email protected]>
@fatcat-z fatcat-z marked this pull request as ready for review June 11, 2024 04:16
@fatcat-z fatcat-z requested a review from xiaowuhu June 11, 2024 04:16
@xadupre xadupre enabled auto-merge June 11, 2024 18:17
@xadupre xadupre disabled auto-merge June 11, 2024 18:20
@xadupre xadupre merged commit 01fcd9b into onnx:main Jun 11, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby left review comments

@xiaowuhu xiaowuhu xiaowuhu approved these changes

@xadupre xadupre xadupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fatcat-z @justinchuby @xiaowuhu @xadupre