-
Notifications
You must be signed in to change notification settings - Fork 69
Oonirun v2.1 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Oonirun v2.1 #301
Conversation
Question: do we want to use headers for this or should we instead make a new post handler which does these in the request body? That would be slightly more flexible if we would like to use this request to pass additional data as part of the first request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look to be breaking changes to the schema. Should the endpoints become .../api/v2.1/...
?
Same as 4.3 GET the OONI Run descriptor | ||
|
||
Note: for dynamically generated run links, this view will only return the | ||
`target_name` and not the `targets` list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way, the users never see the full list of URLs to be tested before installing a Run Link right? Maybe on the mobile clients we need to add a button to see the full list on the web...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is by design though, given that for dynamic test lists (which are currently only derived from the test lists), we cannot know the full list ahead of time as it will change every time you run it.
From the perspective of the UI, we can either show a label that explains these are dynamic and refer to the the test-lists repo to view them. Alternatively we can fetch a batch of URLs from the API endpoint and display that, but make it clear it's just a sample and might change.
], | ||
|
||
// (optional) string used to specify during creation what is the label for targets to use. | ||
"targets_name": "websites_list_prioritized", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will come from a fixed list of options right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we will have a predefined list of these. The client doesn't necessarily need to be aware of all the targets_name, but we will start off with just the websites target list.
The concern here is that |
WIP specification update for OONI Run v2.1
implements ooni/backend#930