Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): implement brotli buffer for compressor #243

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SkandaBhat
Copy link
Contributor

Fixes #176

The implementation ended up being quite similar to #14.

Note that one test fails: compression::brotli::compress::test::test_compress_batch_brotli but the roundtrip test (compresses, decompresses, and checks if we got the same data) passes. Perhaps we should just test roundtrips and not intermediate compressed vs expected? I assume because of the buffer we have the first few bits off.

@SkandaBhat
Copy link
Contributor Author

@refcell are the test_compress_batch_brotli and test_compress_brotli expected? Is there a usecase where we should be testing compressed data against expected data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature] Brotli Compression
1 participant