-
Notifications
You must be signed in to change notification settings - Fork 45
feat: implemented tracking as per spec #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
src/main/java/dev/openfeature/sdk/ImmutableTrackingEventDetails.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package dev.openfeature.sdk; | ||
|
||
import dev.openfeature.sdk.internal.ExcludeFromGeneratedCoverageReport; | ||
import lombok.experimental.Delegate; | ||
|
||
import java.util.Map; | ||
import java.util.Optional; | ||
import java.util.function.Function; | ||
|
||
|
||
/** | ||
* ImmutableTrackingEventDetails represents data pertinent to a particular tracking event. | ||
*/ | ||
public class ImmutableTrackingEventDetails implements TrackingEventDetails { | ||
|
||
@Delegate(excludes = DelegateExclusions.class) | ||
private final ImmutableStructure structure; | ||
|
||
private final Number value; | ||
|
||
public ImmutableTrackingEventDetails() { | ||
this.value = null; | ||
this.structure = new ImmutableStructure(); | ||
} | ||
|
||
public ImmutableTrackingEventDetails(final Number value) { | ||
this.value = value; | ||
this.structure = new ImmutableStructure(); | ||
} | ||
|
||
public ImmutableTrackingEventDetails(final Number value, final Map<String, Value> attributes) { | ||
this.value = value; | ||
this.structure = new ImmutableStructure(attributes); | ||
} | ||
|
||
/** | ||
* Returns the optional tracking value. | ||
*/ | ||
public Optional<Number> getValue() { | ||
return Optional.ofNullable(value); | ||
} | ||
|
||
|
||
@SuppressWarnings("all") | ||
private static class DelegateExclusions { | ||
@ExcludeFromGeneratedCoverageReport | ||
public <T extends Structure> Map<String, Value> merge(Function<Map<String, Value>, Structure> newStructure, | ||
Map<String, Value> base, | ||
Map<String, Value> overriding) { | ||
return null; | ||
} | ||
} | ||
} |
94 changes: 94 additions & 0 deletions
94
src/main/java/dev/openfeature/sdk/MutableTrackingEventDetails.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
package dev.openfeature.sdk; | ||
|
||
import dev.openfeature.sdk.internal.ExcludeFromGeneratedCoverageReport; | ||
import lombok.EqualsAndHashCode; | ||
import lombok.ToString; | ||
import lombok.experimental.Delegate; | ||
|
||
import java.time.Instant; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.Optional; | ||
import java.util.function.Function; | ||
|
||
/** | ||
* MutableTrackingEventDetails represents data pertinent to a particular tracking event. | ||
*/ | ||
@EqualsAndHashCode | ||
@ToString | ||
public class MutableTrackingEventDetails implements TrackingEventDetails { | ||
|
||
private final Number value; | ||
@Delegate(excludes = MutableTrackingEventDetails.DelegateExclusions.class) | ||
private final MutableStructure structure; | ||
|
||
public MutableTrackingEventDetails() { | ||
this.value = null; | ||
this.structure = new MutableStructure(); | ||
} | ||
|
||
public MutableTrackingEventDetails(final Number value) { | ||
this.value = value; | ||
this.structure = new MutableStructure(); | ||
} | ||
|
||
/** | ||
* Returns the optional tracking value. | ||
*/ | ||
public Optional<Number> getValue() { | ||
return Optional.ofNullable(value); | ||
} | ||
|
||
// override @Delegate methods so that we can use "add" methods and still return MutableTrackingEventDetails, | ||
// not Structure | ||
public MutableTrackingEventDetails add(String key, Boolean value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, String value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, Integer value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, Double value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, Instant value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, Structure value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, List<Value> value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
public MutableTrackingEventDetails add(String key, Value value) { | ||
this.structure.add(key, value); | ||
return this; | ||
} | ||
|
||
|
||
@SuppressWarnings("all") | ||
private static class DelegateExclusions { | ||
@ExcludeFromGeneratedCoverageReport | ||
public <T extends Structure> Map<String, Value> merge(Function<Map<String, Value>, Structure> newStructure, | ||
Map<String, Value> base, | ||
Map<String, Value> overriding) { | ||
return null; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.