feat: update test harness with metadata assertions #1467 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfwow
changed the title
aepfli
reviewed
Feb 10, 2025
chrfwow
force-pushed
the
feat-Update-test-harness-with-metadata-assertions-#1467
branch
2 times, most recently
from
974ce86 to
154a1b9
Compare
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
============================================
+ Coverage 92.78% 93.24% +0.45%
- Complexity 465 468 +3
============================================
Files 43 43
Lines 1123 1125 +2
Branches 90 90
============================================
+ Hits 1042 1049 +7
+ Misses 53 48 -5
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
aepfli
approved these changes
Feb 11, 2025
beeme1mr
approved these changes
Feb 13, 2025
aepfli
reviewed
Feb 19, 2025
Signed-off-by: Simon Schrottner <[email protected]>
|
chrfwow
deleted the
feat-Update-test-harness-with-metadata-assertions-#1467
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Implements the gherkin tests added with this PR open-feature/spec#289
Waiting for open-feature/spec#294
Related Issues
Part of open-feature/flagd#1467