Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve registration variables table in admin #4990

Closed
viktorvanwijk opened this issue Jan 7, 2025 · 1 comment · Fixed by #5113
Closed

Improve registration variables table in admin #4990

viktorvanwijk opened this issue Jan 7, 2025 · 1 comment · Fixed by #5113
Assignees
@viktorvanwijk
Labels
owner: dimpact topic: admin

Comments

@viktorvanwijk
Copy link
Contributor

Thema / Theme

Admin

Omschrijving / Description

Currently, it is unclear to which backend the variables in the registration variables table belong, if multiple registration backends are registered and only one of them introduces registration variables (StUF-ZDS in this example):
image
image

Suggestion is to always group the variables like it's done already when two (or more) backends are selected that both introduce registration variables (StUF-ZDS and Objects API in this example):
image
image

Added value / Toegevoegde waarde

Clarity

Aanvullende opmerkingen / Additional context

No response
@viktorvanwijk viktorvanwijk added topic: admin triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement owner: maykin labels Jan 7, 2025
@joeribekker
Copy link
Contributor

Estimate: 1/2 day

@joeribekker joeribekker added owner: dimpact and removed owner: maykin triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 13, 2025
@viktorvanwijk viktorvanwijk self-assigned this Feb 19, 2025
viktorvanwijk added a commit that referenced this issue Feb 19, 2025
@viktorvanwijk
💄 [#4990] Change when plugin fieldset is shown in registration variab…
87fa100 
…les table

Previously, the plugin fieldset was only shown when multiple configured backends introduced registration variables. This led to confusion when there were multiple backends configured, but only ONE of them introduced registration variables. In this case, the registration variables would not be grouped by their plugin name, and it was not clear to which backend they belonged.

Now, the fieldset will only be hidden if there is only ONE configured backend, OR if all the configured backends are of the same type (meaning they introduce the same registration variables).
viktorvanwijk added a commit that referenced this issue Feb 19, 2025
@viktorvanwijk
✅ [#4990] Update tests
8c1cff5
@viktorvanwijk viktorvanwijk mentioned this issue Feb 19, 2025
Merged
10 tasks
@viktorvanwijk viktorvanwijk moved this from Todo to Implemented in Development Feb 19, 2025
viktorvanwijk added a commit that referenced this issue Feb 19, 2025
@viktorvanwijk
✅ [#4990] Update tests
436ab3d
viktorvanwijk added a commit that referenced this issue Feb 20, 2025
@viktorvanwijk
✅ [#4990] Update tests
1bb5d45
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktorvanwijk viktorvanwijk

Labels
owner: dimpact topic: admin
Projects
Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change when plugin fieldset is hidden in registration variables table open-formulieren/open-forms
2 participants
@joeribekker @viktorvanwijk