Change when plugin fieldset is hidden in registration variables table #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les table Previously, the plugin fieldset was only shown when multiple configured backends introduced registration variables. This led to confusion when there were multiple backends configured, but only ONE of them introduced registration variables. In this case, the registration variables would not be grouped by their plugin name, and it was not clear to which backend they belonged. Now, the fieldset will only be hidden if there is only ONE configured backend, OR if all the configured backends are of the same type (meaning they introduce the same registration variables).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5113 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 774 774
Lines 26657 26657
Branches 3468 3468
=======================================
Hits 25787 25787
Misses 608 608
Partials 262 262 ☔ View full report in Codecov by Sentry. |
viktorvanwijk
force-pushed
the
feature/4990-improve-registration-variables-table-in-admin
branch
from
8c1cff5 to
436ab3d
Compare
sergei-maertens
requested changes
Feb 20, 2025
| @@ -369,11 +369,11 @@ export const WithObjectsAPIRegistrationBackends = { | |||
| await userEvent.click(registrationTab); | |||
|
|
|||
| const pdfUrl = canvas.getByRole('cell', {name: 'pdf_url'}); | |||
| expect(pdfUrl).toBeVisible(); | |||
| await expect(pdfUrl).toBeVisible(); | |||
There was a problem hiding this comment.
expect is always sync - possibly you need await canvas.findByRole('cell', {name: 'pdf_url'}); on the line above if there's flakiness due to async stuff happening
There was a problem hiding this comment.
I have gotten used to adding an await before expect calls because my IDE complains about it
src/openforms/js/components/admin/form_design/variables/VariablesEditor.stories.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesEditor.stories.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesEditor.stories.js
Outdated
Show resolved
Hide resolved
viktorvanwijk
force-pushed
the
feature/4990-improve-registration-variables-table-in-admin
branch
from
436ab3d to
1bb5d45
Compare
sergei-maertens
approved these changes
Feb 21, 2025
sergei-maertens
deleted the
feature/4990-improve-registration-variables-table-in-admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4990
Changes
In the registration variables table, the plugin fieldset is now only hidden if there is only one configured backend, or if all the configured backends are of the same type.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene