-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#5016] Add Referentielijsten service select to builder #5036
Open
stevenbal
wants to merge
5
commits into
master
Choose a base branch
from
feature/5016-referentielijsten-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5036 +/- ##
==========================================
+ Coverage 96.72% 96.75% +0.03%
==========================================
Files 770 773 +3
Lines 26517 26702 +185
Branches 3454 3474 +20
==========================================
+ Hits 25649 25836 +187
+ Misses 606 605 -1
+ Partials 262 261 -1 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/5016-referentielijsten-select
branch
from
January 28, 2025 13:23
de085c6
to
98285cb
Compare
stevenbal
changed the base branch from
master
to
feature/4993-referentielijsten-populate-component-choices
January 28, 2025 13:23
Base automatically changed from
feature/4993-referentielijsten-populate-component-choices
to
master
January 28, 2025 16:07
stevenbal
force-pushed
the
feature/5016-referentielijsten-select
branch
2 times, most recently
from
February 3, 2025 10:49
a4c184b
to
c371d68
Compare
stevenbal
commented
Feb 3, 2025
stevenbal
force-pushed
the
feature/5016-referentielijsten-select
branch
2 times, most recently
from
February 3, 2025 14:36
205ac83
to
62aeca6
Compare
and modify the services API endpoint to retrieve referentielijsten services based on a query parameter
this endpoint is used by the formio builder to populate the select widget with tabellen to populate select/selectboxes/radio component options from
and update docker fixtures for Referentielijsten API
stevenbal
force-pushed
the
feature/5016-referentielijsten-select
branch
from
February 3, 2025 14:44
62aeca6
to
e58f408
Compare
Failing docs build is fixed by #5072 |
sergei-maertens
requested changes
Feb 6, 2025
src/openforms/js/components/formio_builder/referentielijsten.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5016 partially
Closes #5025 (due to formio-builder version bump)
Changes
referentielijsten
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene