Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#5016] Add Referentielijsten service select to builder #5036

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 24, 2025

Closes #5016 partially
Closes #5025 (due to formio-builder version bump)

Changes

  • Add Referentielijsten service select to builder
  • Modify Services endpoint to allow filtering by referentielijsten
  • Add endpoint to retrieve referentielijst tabellen

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@stevenbal stevenbal marked this pull request as draft January 24, 2025 15:43
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.75%. Comparing base (3f79ba2) to head (67483fe).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5036      +/-   ##
==========================================
+ Coverage   96.72%   96.75%   +0.03%     
==========================================
  Files         770      773       +3     
  Lines       26517    26702     +185     
  Branches     3454     3474      +20     
==========================================
+ Hits        25649    25836     +187     
+ Misses        606      605       -1     
+ Partials      262      261       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/5016-referentielijsten-select branch from de085c6 to 98285cb Compare January 28, 2025 13:23
@stevenbal stevenbal changed the base branch from master to feature/4993-referentielijsten-populate-component-choices January 28, 2025 13:23
Base automatically changed from feature/4993-referentielijsten-populate-component-choices to master January 28, 2025 16:07
@stevenbal stevenbal force-pushed the feature/5016-referentielijsten-select branch 2 times, most recently from a4c184b to c371d68 Compare February 3, 2025 10:49
@stevenbal stevenbal force-pushed the feature/5016-referentielijsten-select branch 2 times, most recently from 205ac83 to 62aeca6 Compare February 3, 2025 14:36
and modify the services API endpoint to retrieve referentielijsten services based on a query parameter
this endpoint is used by the formio builder to populate the select widget with tabellen to populate select/selectboxes/radio component options from
and update docker fixtures for Referentielijsten API
@stevenbal stevenbal force-pushed the feature/5016-referentielijsten-select branch from 62aeca6 to e58f408 Compare February 3, 2025 14:44
@stevenbal
Copy link
Contributor Author

Failing docs build is fixed by #5072

@stevenbal stevenbal marked this pull request as ready for review February 4, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants