Issue open-horizon#4222 - CWE-732: Insecure Directory Permissions vul…

[LiilyZhang]

…nerabilities

[johnwalicki]

Octal notation? Seems obscure. Especially for security permission settings. 0o777 is 0511
Would it be better to use 0511 or a comment ?

chmod 511 is a+rwx,u-w,g-rw,o-rw
sets permissions so that,
(U)ser / owner can read, can't write and can
execute.
(G)roup can't read, can't write and can execute.
(O)thers can't read, can't write and can execute

[johnwalicki]

https://chmodcommand.com/chmod-511/

Is that really the permissions you want for this directory?

[omordyk]

@johnwalicki these changes did not change anything.
0777: In Go, numbers starting with 0 are interpreted as octal (base-8) by default.
0o777: This is a more explicit octal notation, introduced in Go 1.13.