Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: helloworld - Converge on one Dockerfile #560

Closed
johnwalicki opened this issue Oct 24, 2022 · 0 comments · Fixed by #561
Closed

Feature Request: helloworld - Converge on one Dockerfile #560

johnwalicki opened this issue Oct 24, 2022 · 0 comments · Fixed by #561
Assignees

Comments

@johnwalicki
Copy link
Member

Is your feature request related to a problem? Please describe.

Many of the examples/ repos have Dockerfile.amd64 / Dockerfile.arm / Dockerfile.arm64 / Dockerfile.ppc64le
I did a meld on some of these Dockerfiles and they are slightly different. (which is not good)
These multiple Dockerfiles and differences are unnecessary. We could delete them all. Create one common Dockerfile

Then in the Makefile, tell the docker build --platform linux/$(ARCH)
Docker/Podman will figure out which arch image to pull and build.

Describe the solution you'd like.

Remove all the Dockerfile.* files. Create a common Dockerfile

Describe alternatives you've considered

No response

Additional context.

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant