Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #560 converge helloworld example on one Dockerfile #561

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Issue #560 converge helloworld example on one Dockerfile #561

merged 3 commits into from
Oct 24, 2022

Conversation

johnwalicki
Copy link
Member

@johnwalicki johnwalicki commented Oct 24, 2022 •
edited
Loading

This PR fixes #560

The following changes were made in this PR:

  • Delete the multiple Dockerfile.arch files
  • Add a common Dockerfile that will be used for building all arch containers
  • Modify the Makefile to build using docker build --platform linux/$(ARCH)

@johnwalicki johnwalicki mentioned this pull request Oct 24, 2022
Closed
@johnwalicki johnwalicki requested a review from t-fine October 24, 2022 17:27
@johnwalicki johnwalicki mentioned this pull request Oct 24, 2022
Closed
@johnwalicki johnwalicki changed the title Issue560 one dockerfile Issue #560 converge helloworld examples on one dockerfile Oct 24, 2022
@johnwalicki johnwalicki changed the title Issue #560 converge helloworld examples on one dockerfile Issue #560 converge helloworld example on one Dockerfile Oct 24, 2022
@t-fine t-fine merged commit e82d535 into master Oct 24, 2022
This was referenced Oct 31, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-fine t-fine Awaiting requested review from t-fine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: helloworld - Converge on one Dockerfile
2 participants
@johnwalicki @t-fine