Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong size of mask in RTMDet-Ins post-processing #2581

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

flytocc
Copy link
Contributor

@flytocc flytocc commented Nov 30, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Fix wrong size of mask in rtmdet-ins post-processing. #2580 open-mmlab/mmdetection#11230

Modification

Please briefly describe what modification is made in this PR.

reverse the width and height in scale_factor

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@flytocc flytocc changed the base branch from dev-1.x to main November 30, 2023 17:22
@RunningLeon RunningLeon added the bug Something isn't working label Dec 6, 2023
@RunningLeon RunningLeon self-requested a review December 6, 2023 07:25
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 9ccf2f1 into open-mmlab:main Dec 21, 2023
24 of 28 checks passed
@flytocc flytocc deleted the fix_rtmdet-ins_mask_size branch December 21, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants