Add test for synchronous replication #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test for resource replication, based on client-go FakeDynamicClient to simulate a connection to an actual cluster. The test checks that kube-mgmt reads the resources in this fake cluster and pushes them to a mocked OPA data interface.
Unfortunately,
FakeDynamicClient
brings in a few new dependencies (github.com/pkg/errors, github.com/evanphx/json-patch) and vendors a few more libs. But I think it's worth adding the test, to address confidently some pending issues related to resource sync that I intend to fix (#11, #134)To ease testing, I have modified
data.New
to accept the fakedynamic.Interface
as a parameter, instead of a*rest.Config
, which incidentally also fixes issue #99.I have also refactored
generateSyncPayload
andobjPath
as functions instead of methods, and madesync.Run
receive acontext.Context
instead of returning onequit chan struct{}
per resource, for the sake of easier testing.