feat: add @vianneyyovo as a contributor #686
Conversation
|
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @vianneyyovo! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord
There was a problem hiding this comment.
Hey @vianneyyovo,
Thank you for your contribution! ✨
There are a few things here:
- You have a failed check that you need to address before we can review your PR. Please fix it until all checks pass.
- Please add description to your PR template.
- We have merged a PR before yours. Please resolve the merge conflicts by following these instructions in our course so we can review and merge your PR.
Let me know once you've fixed them, or if you have questions or need help.
Thank you. 🙂
|
Hello @adiati98 , it is ok, you can review again, thanks. |
|
@vianneyyovo, I don't see the badge increase here. You still need to run the command to generate your profile after you resolved the merge conflict. And please also address the failed check. |
|
@adiati98 ok |
|
@adiati98 it is ok |
| @@ -34,7 +34,7 @@ All contributors are required to abide by our [Code of Conduct](https://github.c | |||
| ## All Contributors | |||
|
|
|||
| <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section --> | |||
| [](#contributors-) | |||
| [](#contributors-) | |||
There was a problem hiding this comment.
I'm not sure what's going on here, but all contributors is gone. And we don't want that.
Can you please revert it back to previous version?
Another alternative is to close this PR, and work on a new one.
|
@adiati98 don't worry, i will fix it |
Description
This PR adds @vianneyyovo as a new contributor to the project. It updates the contributors list with the relevant details.
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?