Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @janzengo as a contributor #688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

janzengo
Copy link

Description

This PR adds @janzengo as a contributor.

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #687

Contributors Checklist

I've read through the Getting Started section

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

screenshot

[optional] What GIF best describes this PR or how it makes you feel?

@janzengo janzengo requested a review from a team as a code owner February 23, 2025 11:59
Copy link

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @janzengo! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @janzengo,

Thank you for your contribution! ✨

However, we have merged a PR before yours. Please resolve the merge conflicts by following these instructions in our course before we can review your PR.

Please let me know if you have questions or need any help. 😊

@janzengo janzengo requested a review from adiati98 February 24, 2025 09:06
@janzengo
Copy link
Author

janzengo commented Feb 24, 2025

Hi @adiati98! I have resolved the conflicts according to latest PR Merges. Thank you!

@adiati98
Copy link
Member

@janzengo, I see that the badge doesn't increase here. You also need to run the command to generate your profile after you resolve the conflicts.

@janzengo
Copy link
Author

@adiati98 Hi! I followed the instructions and pushed a commit solving all merge conflicts. (I used npm run contributors:generate)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add @janzengo as a contributor
2 participants