-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add @janzengo as a contributor #688
base: main
Are you sure you want to change the base?
Conversation
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @janzengo! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @janzengo,
Thank you for your contribution! ✨
However, we have merged a PR before yours. Please resolve the merge conflicts by following these instructions in our course before we can review your PR.
Please let me know if you have questions or need any help. 😊
Hi @adiati98! I have resolved the conflicts according to latest PR Merges. Thank you! |
@janzengo, I see that the badge doesn't increase here. You also need to run the command to generate your profile after you resolve the conflicts. |
@adiati98 Hi! I followed the instructions and pushed a commit solving all merge conflicts. (I used Thank you! |
Description
This PR adds @janzengo as a contributor.
What type of PR is this? (check all applicable)
Related Issues
Closes #687
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generate
to generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?