Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confmap] - new feature flag for append merging strategy #12097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VihasMakwana
Copy link
Contributor

Koanf's default merging strategy currently overrides static values such as slices, numbers, and strings. However, lists of components should be treated as a special case. This pull request introduces a new feature gate to allow for merging lists instead of discarding the existing ones.

With this new merging strategy:

  • Lists under the service configuration are merged rather than replaced.
  • The merging logic is name-aware, meaning that if components with the same name appear in both lists, they will only appear once in the final merged list.
  • This strategy only affects configurations under service::*.

Link to tracking issue

Related issues:

Testing

  • Added

Documentation

  • To be added

Note: I’d appreciate your feedback on this 🙏

@VihasMakwana VihasMakwana requested review from evan-bradley, a team and mx-psi as code owners January 15, 2025 13:52
confmap/confmap.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants