-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove unnecessary usage of nolint:gosec #12112
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12112 +/- ##
==========================================
- Coverage 91.67% 91.67% -0.01%
==========================================
Files 461 461
Lines 24749 24740 -9
==========================================
- Hits 22689 22680 -9
Misses 1678 1678
Partials 382 382 ☔ View full report in Codecov by Sentry. |
I don't think they were incorrect, but the rules were relaxed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for chlog here.
So, all we need to do is add exclude rules and then ignore them, right? |
.golangci.yml
Outdated
- text: "G115:" | ||
linters: | ||
- gosec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused, I did not see that you excluded it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that you excluded. We should not exclude the rule, but fix the usage.
@bogdandrutu |
d18283b
to
df7ffa6
Compare
df7ffa6
to
de25735
Compare
Description
// nolint:gosec
introduced by PR fix(deps): update module github.com/golangci/golangci-lint to v1.61.0 #10935Link to tracking issue
Fixes #11425
Testing
Documentation