add test for Mac OS and Windows #1934
Conversation
|
@trask can you help with the windows error? |
I think you need to add double quotes below
|
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| @EnabledOnOs(LINUX) // Uses async-profiler, which is only supported on Linux |
There was a problem hiding this comment.
async profiler works on mac, see https://github.com/async-profiler/async-profiler
.github/workflows/build.yml
Outdated
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
was this needed?
| env: | |
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
the rate limit kicked in due to the parallel builds here: https://github.com/zeitlinger/opentelemetry-java-contrib/blob/c4b126be51817af8c2a95b6d54ba8ab9343077e7/opamp-client/build.gradle.kts#L21
There was a problem hiding this comment.
interesting, the problem is that secrets aren't available on PR builds, so I don't think this will help (we have similar problem on link checking workflows)
There was a problem hiding this comment.
looks like you're right: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication
let me do some testing, I'm not sure why this didn't help with the link check workflows...
There was a problem hiding this comment.
finally got to the bottom of why I didn't think it worked before (was because of a bug) 😅: open-telemetry/semantic-conventions#2352 (comment)
There was a problem hiding this comment.
great - is this PR ready then?
There was a problem hiding this comment.
@trask can you take a look?
There was a problem hiding this comment.
I'm still not following how hitting only a single url would require GH_TOKEN, it's not like link checking where we are hitting 100s or 1000s of urls, so I reverted this part to investigate, but not seeing the failure that you were seeing earlier
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
same
| env: | |
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
| coverage: true | ||
| jmh-based-tests: true |
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - id: setup-test-java | ||
| name: Set up JDK ${{ matrix.test-java-version }} for running tests | ||
| - id: setup-java-test |
There was a problem hiding this comment.
id is renamed here but not its usage below
Relates #1907
Using the same config as https://github.com/open-telemetry/opentelemetry-java/blob/main/.github/workflows/build.yml