Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP header supplier configuration option #6004

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,2 +1,19 @@
Comparing source compatibility of against
No changes.
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.exporter.otlp.http.logs.OtlpHttpLogRecordExporterBuilder (not serializable)
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.exporter.otlp.http.logs.OtlpHttpLogRecordExporterBuilder setHeaders(java.util.function.Supplier<java.util.Map<java.lang.String,java.lang.String>>)
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.exporter.otlp.http.metrics.OtlpHttpMetricExporterBuilder (not serializable)
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.exporter.otlp.http.metrics.OtlpHttpMetricExporterBuilder setHeaders(java.util.function.Supplier<java.util.Map<java.lang.String,java.lang.String>>)
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.exporter.otlp.http.trace.OtlpHttpSpanExporterBuilder (not serializable)
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.exporter.otlp.http.trace.OtlpHttpSpanExporterBuilder setHeaders(java.util.function.Supplier<java.util.Map<java.lang.String,java.lang.String>>)
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.exporter.otlp.logs.OtlpGrpcLogRecordExporterBuilder (not serializable)
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.exporter.otlp.logs.OtlpGrpcLogRecordExporterBuilder setHeaders(java.util.function.Supplier<java.util.Map<java.lang.String,java.lang.String>>)
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.exporter.otlp.metrics.OtlpGrpcMetricExporterBuilder (not serializable)
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.exporter.otlp.metrics.OtlpGrpcMetricExporterBuilder setHeaders(java.util.function.Supplier<java.util.Map<java.lang.String,java.lang.String>>)
*** MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporterBuilder (not serializable)
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporterBuilder setHeaders(java.util.function.Supplier<java.util.Map<java.lang.String,java.lang.String>>)
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import io.opentelemetry.sdk.common.export.RetryPolicy;
import java.net.URI;
import java.time.Duration;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.ServiceLoader;
Expand Down Expand Up @@ -49,7 +50,8 @@
private long timeoutNanos;
private URI endpoint;
private boolean compressionEnabled = false;
private final Map<String, String> headers = new HashMap<>();
private Map<String, String> staticHeaders = new HashMap<>();
private Supplier<Map<String, String>> headerSupplier = Collections::emptyMap;
private TlsConfigHelper tlsConfigHelper = new TlsConfigHelper();
@Nullable private RetryPolicy retryPolicy;
private Supplier<MeterProvider> meterProviderSupplier = GlobalOpenTelemetry::getMeterProvider;
Expand Down Expand Up @@ -113,8 +115,16 @@
return this;
}

public GrpcExporterBuilder<T> addHeader(String key, String value) {
headers.put(key, value);
public GrpcExporterBuilder<T> addStaticHeader(String key, String value) {
if (staticHeaders == null) {
staticHeaders = new HashMap<>();

Check warning on line 120 in exporters/common/src/main/java/io/opentelemetry/exporter/internal/grpc/GrpcExporterBuilder.java

View check run for this annotation

Codecov / codecov/patch

exporters/common/src/main/java/io/opentelemetry/exporter/internal/grpc/GrpcExporterBuilder.java#L120

Added line #L120 was not covered by tests
}
staticHeaders.put(key, value);
return this;
}

public GrpcExporterBuilder<T> setHeadersSupplier(Supplier<Map<String, String>> headerSupplier) {
breedx-splk marked this conversation as resolved.
Show resolved Hide resolved
this.headerSupplier = headerSupplier;
return this;
}

Expand Down Expand Up @@ -142,7 +152,8 @@
copy.timeoutNanos = timeoutNanos;
copy.endpoint = endpoint;
copy.compressionEnabled = compressionEnabled;
copy.headers.putAll(headers);
copy.staticHeaders.putAll(staticHeaders);
copy.headerSupplier = headerSupplier;
copy.tlsConfigHelper = tlsConfigHelper.copy();
if (retryPolicy != null) {
copy.retryPolicy = retryPolicy.toBuilder().build();
Expand All @@ -153,14 +164,25 @@
}

public GrpcExporter<T> build() {
Supplier<Map<String, String>> headerSupplier =
() -> {
Map<String, String> result = new HashMap<>();
Map<String, String> supplierResult = this.headerSupplier.get();
if (supplierResult != null) {
result.putAll(supplierResult);
}
result.putAll(staticHeaders);
return result;
};

GrpcSenderProvider grpcSenderProvider = resolveGrpcSenderProvider();
GrpcSender<T> grpcSender =
grpcSenderProvider.createSender(
endpoint,
grpcEndpointPath,
compressionEnabled,
timeoutNanos,
headers,
headerSupplier,
grpcChannel,
grpcStubFactory,
retryPolicy,
Expand All @@ -183,7 +205,11 @@
joiner.add("timeoutNanos=" + timeoutNanos);
joiner.add("compressionEnabled=" + compressionEnabled);
StringJoiner headersJoiner = new StringJoiner(", ", "Headers{", "}");
headers.forEach((key, value) -> headersJoiner.add(key + "=OBFUSCATED"));
staticHeaders.forEach((key, value) -> headersJoiner.add(key + "=OBFUSCATED"));
Map<String, String> headers = headerSupplier.get();
if (headers != null) {
headers.forEach((key, value) -> headersJoiner.add(key + "=OBFUSCATED"));
}
joiner.add("headers=" + headersJoiner);
if (retryPolicy != null) {
joiner.add("retryPolicy=" + retryPolicy);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <T extends Marshaler> GrpcSender<T> createSender(
String endpointPath,
boolean compressionEnabled,
long timeoutNanos,
Map<String, String> headers,
Supplier<Map<String, String>> headersSupplier,
@Nullable Object managedChannel,
Supplier<BiFunction<Channel, String, MarshalerServiceStub<T, ?, ?>>> stubFactory,
@Nullable RetryPolicy retryPolicy,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
private long timeoutNanos = TimeUnit.SECONDS.toNanos(DEFAULT_TIMEOUT_SECS);
private boolean compressionEnabled = false;
private boolean exportAsJson = false;
@Nullable private Map<String, String> headers;
private Map<String, String> staticHeaders = new HashMap<>();
private Supplier<Map<String, String>> headerSupplier = Collections::emptyMap;

private TlsConfigHelper tlsConfigHelper = new TlsConfigHelper();
@Nullable private RetryPolicy retryPolicy;
Expand Down Expand Up @@ -82,11 +83,16 @@
return this;
}

public HttpExporterBuilder<T> addHeader(String key, String value) {
if (headers == null) {
headers = new HashMap<>();
public HttpExporterBuilder<T> addStaticHeader(String key, String value) {
jack-berg marked this conversation as resolved.
Show resolved Hide resolved
if (staticHeaders == null) {
staticHeaders = new HashMap<>();

Check warning on line 88 in exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporterBuilder.java

View check run for this annotation

Codecov / codecov/patch

exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporterBuilder.java#L88

Added line #L88 was not covered by tests
}
headers.put(key, value);
staticHeaders.put(key, value);
return this;
}

public HttpExporterBuilder<T> setHeadersSupplier(Supplier<Map<String, String>> headerSupplier) {
this.headerSupplier = headerSupplier;
return this;
}

Expand Down Expand Up @@ -134,9 +140,8 @@
copy.timeoutNanos = timeoutNanos;
copy.exportAsJson = exportAsJson;
copy.compressionEnabled = compressionEnabled;
if (headers != null) {
copy.headers = new HashMap<>(headers);
}
copy.staticHeaders.putAll(staticHeaders);
copy.headerSupplier = headerSupplier;
copy.tlsConfigHelper = tlsConfigHelper.copy();
if (retryPolicy != null) {
copy.retryPolicy = retryPolicy.toBuilder().build();
Expand All @@ -147,8 +152,16 @@
}

public HttpExporter<T> build() {
Map<String, String> headers = this.headers == null ? Collections.emptyMap() : this.headers;
Supplier<Map<String, String>> headerSupplier = () -> headers;
Supplier<Map<String, String>> headerSupplier =
() -> {
Map<String, String> result = new HashMap<>();
Map<String, String> supplierResult = this.headerSupplier.get();
if (supplierResult != null) {
result.putAll(supplierResult);
}
result.putAll(staticHeaders);
return result;
};

HttpSenderProvider httpSenderProvider = resolveHttpSenderProvider();
HttpSender httpSender =
Expand Down Expand Up @@ -178,11 +191,13 @@
joiner.add("timeoutNanos=" + timeoutNanos);
joiner.add("compressionEnabled=" + compressionEnabled);
joiner.add("exportAsJson=" + exportAsJson);
StringJoiner headersJoiner = new StringJoiner(", ", "Headers{", "}");
staticHeaders.forEach((key, value) -> headersJoiner.add(key + "=OBFUSCATED"));
Map<String, String> headers = headerSupplier.get();
if (headers != null) {
StringJoiner headersJoiner = new StringJoiner(", ", "Headers{", "}");
headers.forEach((key, value) -> headersJoiner.add(key + "=OBFUSCATED"));
joiner.add("headers=" + headersJoiner);
}
joiner.add("headers=" + headersJoiner);
if (retryPolicy != null) {
joiner.add("retryPolicy=" + retryPolicy);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ public void setUp() {
"otlp",
"span",
new UpstreamGrpcSender<>(
MarshalerTraceServiceGrpc.newFutureStub(defaultGrpcChannel, null), 10),
MarshalerTraceServiceGrpc.newFutureStub(defaultGrpcChannel, null),
10,
Collections::emptyMap),
MeterProvider::noop);

okhttpGrpcSender =
Expand All @@ -97,7 +99,7 @@ public void setUp() {
.toString(),
/* compressionEnabled= */ false,
10,
Collections.emptyMap(),
Collections::emptyMap,
null,
null,
null),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import io.opentelemetry.exporter.otlp.internal.OtlpUserAgent;
import io.opentelemetry.sdk.common.export.RetryPolicy;
import java.time.Duration;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import javax.net.ssl.SSLContext;
Expand All @@ -33,7 +34,7 @@ public final class OtlpHttpLogRecordExporterBuilder {

OtlpHttpLogRecordExporterBuilder(HttpExporterBuilder<LogsRequestMarshaler> delegate) {
this.delegate = delegate;
OtlpUserAgent.addUserAgentHeader(delegate::addHeader);
OtlpUserAgent.addUserAgentHeader(delegate::addStaticHeader);
}

OtlpHttpLogRecordExporterBuilder() {
Expand Down Expand Up @@ -83,9 +84,15 @@ public OtlpHttpLogRecordExporterBuilder setCompression(String compressionMethod)
return this;
}

/** Add header to requests. */
/** Add static header to requests. */
public OtlpHttpLogRecordExporterBuilder addHeader(String key, String value) {
delegate.addHeader(key, value);
delegate.addStaticHeader(key, value);
return this;
}

/** Set the supplier of headers to add to requests. */
public OtlpHttpLogRecordExporterBuilder setHeaders(Supplier<Map<String, String>> headerSupplier) {
delegate.setHeadersSupplier(headerSupplier);
return this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
import io.opentelemetry.sdk.metrics.export.DefaultAggregationSelector;
import io.opentelemetry.sdk.metrics.export.MetricExporter;
import java.time.Duration;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import javax.net.ssl.SSLContext;
import javax.net.ssl.X509TrustManager;

Expand All @@ -44,7 +46,7 @@ public final class OtlpHttpMetricExporterBuilder {
OtlpHttpMetricExporterBuilder(HttpExporterBuilder<MetricsRequestMarshaler> delegate) {
this.delegate = delegate;
delegate.setMeterProvider(MeterProvider::noop);
OtlpUserAgent.addUserAgentHeader(delegate::addHeader);
OtlpUserAgent.addUserAgentHeader(delegate::addStaticHeader);
}

OtlpHttpMetricExporterBuilder() {
Expand Down Expand Up @@ -94,9 +96,15 @@ public OtlpHttpMetricExporterBuilder setCompression(String compressionMethod) {
return this;
}

/** Add header to requests. */
/** Add static header to requests. */
public OtlpHttpMetricExporterBuilder addHeader(String key, String value) {
delegate.addHeader(key, value);
delegate.addStaticHeader(key, value);
return this;
}

/** Set the supplier of headers to add to requests. */
public OtlpHttpMetricExporterBuilder setHeaders(Supplier<Map<String, String>> headerSupplier) {
delegate.setHeadersSupplier(headerSupplier);
return this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import io.opentelemetry.exporter.otlp.internal.OtlpUserAgent;
import io.opentelemetry.sdk.common.export.RetryPolicy;
import java.time.Duration;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import javax.net.ssl.SSLContext;
Expand All @@ -33,7 +34,7 @@ public final class OtlpHttpSpanExporterBuilder {

OtlpHttpSpanExporterBuilder(HttpExporterBuilder<TraceRequestMarshaler> delegate) {
this.delegate = delegate;
OtlpUserAgent.addUserAgentHeader(delegate::addHeader);
OtlpUserAgent.addUserAgentHeader(delegate::addStaticHeader);
}

OtlpHttpSpanExporterBuilder() {
Expand Down Expand Up @@ -83,9 +84,15 @@ public OtlpHttpSpanExporterBuilder setCompression(String compressionMethod) {
return this;
}

/** Add header to requests. */
/** Add static header to requests. */
public OtlpHttpSpanExporterBuilder addHeader(String key, String value) {
delegate.addHeader(key, value);
delegate.addStaticHeader(key, value);
return this;
}

/** Set the supplier of headers to add to requests. */
public OtlpHttpSpanExporterBuilder setHeaders(Supplier<Map<String, String>> headerSupplier) {
delegate.setHeadersSupplier(headerSupplier);
return this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import io.opentelemetry.sdk.common.export.RetryPolicy;
import java.net.URI;
import java.time.Duration;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import javax.net.ssl.SSLContext;
Expand All @@ -43,7 +44,7 @@ public final class OtlpGrpcLogRecordExporterBuilder {

OtlpGrpcLogRecordExporterBuilder(GrpcExporterBuilder<LogsRequestMarshaler> delegate) {
this.delegate = delegate;
OtlpUserAgent.addUserAgentHeader(delegate::addHeader);
OtlpUserAgent.addUserAgentHeader(delegate::addStaticHeader);
}

OtlpGrpcLogRecordExporterBuilder() {
Expand Down Expand Up @@ -159,7 +160,16 @@ public OtlpGrpcLogRecordExporterBuilder setSslContext(
* @return this builder's instance
*/
public OtlpGrpcLogRecordExporterBuilder addHeader(String key, String value) {
delegate.addHeader(key, value);
delegate.addStaticHeader(key, value);
return this;
}

/**
* Set the supplier of headers to add to requests. Applicable only if {@link
* OtlpGrpcLogRecordExporterBuilder#setChannel(ManagedChannel)} is not used to set channel.
*/
public OtlpGrpcLogRecordExporterBuilder setHeaders(Supplier<Map<String, String>> headerSupplier) {
delegate.setHeadersSupplier(headerSupplier);
return this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
import io.opentelemetry.sdk.metrics.export.MetricExporter;
import java.net.URI;
import java.time.Duration;
import java.util.Map;
import java.util.concurrent.TimeUnit;
import java.util.function.Supplier;
import javax.net.ssl.SSLContext;
import javax.net.ssl.X509TrustManager;

Expand Down Expand Up @@ -54,7 +56,7 @@ public final class OtlpGrpcMetricExporterBuilder {
OtlpGrpcMetricExporterBuilder(GrpcExporterBuilder<MetricsRequestMarshaler> delegate) {
this.delegate = delegate;
delegate.setMeterProvider(MeterProvider::noop);
OtlpUserAgent.addUserAgentHeader(delegate::addHeader);
OtlpUserAgent.addUserAgentHeader(delegate::addStaticHeader);
}

OtlpGrpcMetricExporterBuilder() {
Expand Down Expand Up @@ -171,7 +173,16 @@ public OtlpGrpcMetricExporterBuilder setSslContext(
* @return this builder's instance
*/
public OtlpGrpcMetricExporterBuilder addHeader(String key, String value) {
delegate.addHeader(key, value);
delegate.addStaticHeader(key, value);
return this;
}

/**
* Set the supplier of headers to add to requests. Applicable only if {@link
* OtlpGrpcMetricExporterBuilder#setChannel(ManagedChannel)} is not used to set channel.
*/
public OtlpGrpcMetricExporterBuilder setHeaders(Supplier<Map<String, String>> headerSupplier) {
delegate.setHeadersSupplier(headerSupplier);
return this;
}

Expand Down
Loading