Upgrade OTLP proto to v1.7. #4645
Merged
+1,756
−1,526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
1 task
DylanRussell
changed the title
event_name to LogRecord API/SDK/PROTO
emdneto
added
the
Approve Public API check
|
Hmm we could do it separately.. Proto change doesn't require it. I'm heading out for weekend but can break it out on Monday if you think that's cleaner |
DylanRussell
changed the title
event_name to LogRecord API/SDK/PROTO
|
Ok I backed off the changes adding support for event name |
|
Once this is submitted I'll make a new PR for those |
1 task
|
Created #4652 to add the field to the LogRecord |
emdneto
approved these changes
Jun 23, 2025
aabmass
approved these changes
Jun 23, 2025
aabmass
approved these changes
Jun 23, 2025
opentelemetry-proto/src/opentelemetry/proto/collector/logs/v1/logs_service_pb2_grpc.py
Show resolved
Hide resolved
aabmass
approved these changes
Jun 23, 2025
opentelemetry-proto/src/opentelemetry/proto/collector/logs/v1/logs_service_pb2_grpc.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to proto 1.7. The file diffs make it very hard to tell what has actually changed. Wish there were a better way to see actual diffs.
From reading through https://github.com/open-telemetry/opentelemetry-proto/releases -- most of the changes are to profiling which we don't support AFAICT, so I don't think we have to worry about that at all.
The only other notable change is that the
EventNamefield was added to theLogRecordproto... I opened up #4644 for that. I plan to make a PR to add support for this field once this PR is submitted.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: